Selector method of UIButton not called during animation

Question

I have dynamically created buttons on a dynamic view and later I add that dynamic view to main view.
Everything is working well except that the selector method of UIButton is not called.

var baseView:UIView?
    override func viewDidLoad() {
        super.viewDidLoad()
        randomizeButtons()}
    func randomizeButtons(){


        baseView = UIView(frame:CGRectMake(view.bounds.origin.x + 10, view.bounds.origin.y + 50, view.bounds.size.width, view.bounds.size.height-20))
        let viewWidth = baseView.bounds.size.width;
        let viewHeight = baseView.bounds.size.height;

        baseView.userInteractionEnabled = true
        let  i = GlobalArrayofUsers.count
        var loopCount = 0
        while loopCount < i{

            let  userBaseView = UIView(frame: CGRectMake(abs(CGFloat(arc4random()) % viewWidth - 90) , abs(CGFloat(arc4random()) % viewHeight - 120), 90, 90))
            print(userBaseView.frame)
            userBaseView.backgroundColor = UIColor.redColor()
            userBaseView.userInteractionEnabled = true

            userBaseView.layer.cornerRadius = 45
            userBaseView.clipsToBounds = true


            let button = UIButton(frame: userBaseView.bounds)
            button.backgroundColor = UIColor.greenColor()
            button.showsTouchWhenHighlighted = true
            button.addTarget(self, action: #selector(ViewController.handleTapEventofBtn(_:)), forControlEvents: .TouchUpInside)
            button.setTitle("hello", forState: .Normal)
            button.userInteractionEnabled = true
            userBaseView.addSubview(button)
            baseView.addSubview(userBaseView)
            print("button  frame is\(button.frame)")
            baseView.bringSubviewToFront(userBaseView)

            loopCount += 1

        }
    }
    baseView.subviews.forEach { (users) in
    UIView.animateWithDuration(1, delay: 0, options: [.Autoreverse,.Repeat], animations: {
    users.center.y += 10
    }, completion: nil)
    }
    view.insertSubview(baseView, atIndex: view.subviews.count)

}

func handleTapEventofBtn(sender: UIButton!) {
    // handling code
}

Any idea why my selector method is not called? It is due to animation. How can i handle it.

SOLUTION: Allow userinteraction in UIAnimationOptions

Have you tried by replacing self with yourcontrollername in button target ? — Jigar Tarsariya, May 04 '16 at 09:55
Your code works when I throw it in a viewController. Can you update your question to show the entire code of your viewController? — vacawama, May 04 '16 at 10:24
The code presented above works. You are doing something else in your real code to cause the problem. — vacawama, May 04 '16 at 10:50
@vacawama It is due to the animation block. If i comment it, everything works fine — ankit, May 04 '16 at 11:26
@NA000022 all i did was making it more readable. solving an issue should never be done through an edit of the question by someone else than OP. — GottZ, May 04 '16 at 14:14

Daniel · Accepted Answer · 2016-05-04T12:28:19.230

4

The problem is that you are trying to click an object that is being animated. From the docs:

During an animation, user interactions are temporarily disabled for the views being animated. (Prior to iOS 5, user interactions are disabled for the entire application.)

But worry not, the solution is very easy, just call your animation with the option .AllowUserInteraction. For example (with your code):

UIView.animateWithDuration(1, delay: 0, options: [.Autoreverse,.Repeat,.AllowUserInteraction], animations: {
    users.center.y += 10
}, completion: nil)

edited May 04 '16 at 12:28

answered May 04 '16 at 10:52

Daniel

20,420
10
92
149

Please check my new code. If i use animation it doesn't work – ankit May 04 '16 at 11:17
@NA000022 Your code would not work anymore since `baseView` is never initialized + users is unknown – Daniel May 04 '16 at 12:00
It is initialed now. The problem was due to animation , since i haven't added userInteraction in UIViewAnimation options – ankit May 04 '16 at 12:06
@NA000022 I could reproduce it + problem solved (see my update) – Daniel May 04 '16 at 12:15

score 0 · Answer 2 · edited May 06 '16 at 11:35

0

Have you tried this way:

for _ in 0...5{
    // generate new view
    let userBaseView = UIView(frame: CGRectMake(abs(CGFloat(arc4random()) % viewWidth - 90) , abs(CGFloat(arc4random()) % viewHeight - 120), 90, 90))
    userBaseView.backgroundColor = UIColor.redColor()
    // add button to view
    let button = UIButton(frame: userBaseView.bounds)
    button.backgroundColor = UIColor.yellowColor()
    button.showsTouchWhenHighlighted = true
    button.addTarget(self, action: #selector(self.handleTapEventofBtn(_:)), forControlEvents: .TouchUpInside)
    button.setTitle("hello", forState: .Normal)
    userBaseView.addSubview(button)
}
self.view.addSubview(userBaseView)

All you need is to create userBaseView before cycle, then create buttons in cycle and add them to userBaseView, after that just add userBaseView to self.view or where you need to add it. In your example you create userBaseView in every iteration of the loop.

I think the problem could be here:

userBaseView.addSubview(button)
    // add new view containing button to self.view
    self.view.addSubview(userBaseView)
}

userBaseView.addSubview(button)
baseView.addSubview(userBaseView)

First you add userBaseView to self.view in the loop:

// add new view containing button to self.view
self.view.addSubview(userBaseView)

then add it to baseView:

baseView.addSubview(userBaseView)

Can you post how it looks like in IB?

edited May 06 '16 at 11:35

GottZ

4,824
1
36
46

answered May 04 '16 at 09:42

Alex Kosyakov

2,095
1
17
25

But I want the userBaseView to be dynamic as well. – ankit May 04 '16 at 09:47
I am doing it all programatically. – ankit May 04 '16 at 10:25
Ok, can you show the result on the screen? PS, Also pls check that your userBaseView & baseView are userInteractionEnable = true – Alex Kosyakov May 04 '16 at 10:39
One more thing, have you got any gesture recognizers on the screen? – Alex Kosyakov May 04 '16 at 10:40
No there are not any gestures. – ankit May 04 '16 at 10:43
Also userInteraction is enabled as well – ankit May 04 '16 at 10:48
So probably the problem isn't here, are you adding any other subviews to view? Can you post more code from this vc? – Alex Kosyakov May 04 '16 at 10:55
It is only due to animation block. If i comment it , it works – ankit May 04 '16 at 11:19

score 0 · Answer 3 · edited May 06 '16 at 11:37

0

// hi. your problem is in the selector line. try this:

for _ in 0...5 {
    // generate new view
    let  userBaseView = UIView(frame: CGRectMake(abs(CGFloat(arc4random()) % self.view.frame.size.width - 90) , abs(CGFloat(arc4random()) % self.view.frame.size.height - 120), 90, 90))
    userBaseView.backgroundColor = UIColor.redColor()
    // add button to view
    let button = UIButton(frame: userBaseView.bounds)
    button.backgroundColor = UIColor.yellowColor()
    button.showsTouchWhenHighlighted = true

    button.addTarget(self, action: "buttonAction", forControlEvents: UIControlEvents.TouchUpInside)

    button.setTitle("hello", forState: .Normal)
    userBaseView.addSubview(button)
    self.view.addSubview(userBaseView)
}

// tested with xcode 7.2

func buttonAction() {
    print("working")
}

edited May 06 '16 at 11:37

GottZ

4,824
1
36
46

answered May 04 '16 at 10:10

Harris

310
3
13

No selector method is ok. I have checked that. – ankit May 04 '16 at 10:14
is the method being called then? – Harris May 04 '16 at 10:17
No it is not being called anyway – ankit May 04 '16 at 10:21
using this also doesn't help? : button.addTarget(self, action: "buttonAction", forControlEvents: UIControlEvents.TouchUpInside) – Harris May 04 '16 at 10:24

score 0 · Answer 4 · edited May 06 '16 at 11:35

The action has a parameter so the selector signature is actually takeActionBtn:
(note the colon at the end).
You need to change that or the button will try to call a version of the function with no parameter which doesn't exist.

button.addTarget(self, action: "button:",forControlEvents: UIControlEvents.TouchUpInside)

func button(sender: UIButton!) {
    // handling code
    print("1")
}

Selector method of UIButton not called during animation

4 Answers4