A broadcast receiver inside a service isnt working

Question

I have a receiver inside a service as i need the scheduled alarm to work even when the activity is destroyed. This is what i have done.

/**
 * Created by rishabh on 14/2/16.
 */
public class MyService  extends Service {

@Nullable
@Override
public IBinder onBind(Intent intent) {
    return null;
}

public class MyReceiver extends BroadcastReceiver{

    @Override
    public void onReceive(Context context, Intent intent) {
        Calendar c = Calendar.getInstance();
        int hour=c.get(Calendar.HOUR_OF_DAY);
        int minute=c.get(Calendar.MINUTE);
        Calendar calendar = new GregorianCalendar(1990, 1, 1, hour, minute);
        SimpleDateFormat sdf = new SimpleDateFormat("hh:mm");
        String date = sdf.format(calendar.getTime());
        String str=date.charAt(0)+""+date.charAt(1)+""+date.charAt(3)+""+date.charAt(4);
        String LOG_TAG="DevicePolicyAdmin";
        Log.v(LOG_TAG, "Service Started");
        MainActivity.minochaDevicePolicyManager.resetPassword(str, 0);
    }
}
}

And to trigger the receiver the scheduling alarm is here

    Intent intent3=new Intent(MainActivity.this,MyService.class);
    startService(intent3);
            Intent intent2 = new Intent(MainActivity.this, MyService.MyReceiver.class);
            PendingIntent pintent = PendingIntent.getService(MainActivity.this, 0, intent2, 0);
            AlarmManager alarm = (AlarmManager) getSystemService(Context.ALARM_SERVICE);
            alarm.setRepeating(AlarmManager.RTC_WAKEUP, c.getTimeInMillis(), 60 * 1000, pintent);

The onReceive method in the MyService class only executes once. why? What could be the issue. Please help

Did you try giving the service and Receiver in separate classes.Then try calling the service from receiver using startService method(). — srinivas, Mar 22 '16 at 10:27

Silvans Solanki · Answer 1 · 2016-03-22T09:31:25.833

0

you need to register it in service as follows,

IntentFilter filter = new IntentFilter();
  filter.addAction("SOME_ACTION");
  filter.addAction("SOME_OTHER_ACTION");

context.registerReceiver(receiver, filter);

Also in onReceive method you need to check for the action of broadcast receiver fired for.

Hope this will help you.

edited Mar 22 '16 at 09:31

answered Mar 22 '16 at 09:29

Silvans Solanki

1,267
1
14
27

where do i add this? and what action do i add? – AxeManTOBO Mar 22 '16 at 09:31
what exactly you want to achieve in your service so i can answer you in better way. – Silvans Solanki Mar 22 '16 at 09:32
the code is there. what i want to do is that the receiver should be on 24/7 and should not be closed when the activity is destroyed – AxeManTOBO Mar 22 '16 at 09:34

score 0 · Answer 2 · answered Mar 22 '16 at 09:40

0

One of your problems is that your getting a service using the intent which use the broadcast receiver. Start changing this:

PendingIntent pintent = PendingIntent.getService(MainActivity.this, 0, intent2, 0);

For this:

PendingIntent pintent = PendingIntent.getService(MainActivity.this, 0, intent3, 0);

answered Mar 22 '16 at 09:40

Miguel Benitez

2,322
10
22

if i do that whats the point of intent 2. its not doing anything – AxeManTOBO Mar 22 '16 at 09:46
If you want to get the broadcast you should use getBroadcast instead of getService – Miguel Benitez Mar 22 '16 at 09:47

score 0 · Accepted Answer · edited May 23 '17 at 11:50

0

Try moving MyReceiver to an independent file as public class and use this code to start.

 Intent intent2 = new Intent(getApplicationContext(), MyReceiver.class);
            PendingIntent pintent = PendingIntent.getService(getApplicationContext(), 0, intent2, 0);
            AlarmManager alarm = (AlarmManager) getSystemService(Context.ALARM_SERVICE);
            alarm.setRepeating(AlarmManager.RTC_WAKEUP, c.getTimeInMillis(), 60 * 1000, pintent);

Update 1 :

This may help you -How to repeat my service using alarm manager?

Update 2 : Check this too- Android - Periodic Background Service - Advice

edited May 23 '17 at 11:50

Community

1
1

answered Mar 22 '16 at 09:46

Arun Shankar

2,603
2
26
36

but how will i trigger the service after each minute? – AxeManTOBO Mar 22 '16 at 09:48
Use an AlarmManager with an intent having action "com.xyz.action" (or your action) – Arun Shankar Mar 22 '16 at 09:49
but what filter? my need for the service is completely different and doesnt exactly need an action – AxeManTOBO Mar 22 '16 at 09:52
An action is there to trigger a service. Without an action, how can you initiate a service with an implicit intent? – Arun Shankar Mar 22 '16 at 09:53
If you want to trigger a service every minute, using alarm manager with an explicit intent 'new Intent(cintext, YourService.class);' can do the job. No need of any filters of receivers. – Arun Shankar Mar 22 '16 at 09:55
But if you want to trigger a service based on conditions, you need intents with Actions. – Arun Shankar Mar 22 '16 at 09:55
thats what i have done havent i? new intent (MainActivity,Service.class) – AxeManTOBO Mar 22 '16 at 09:55
but the trigger is the time! i need it to repeat every 1 minute. – AxeManTOBO Mar 22 '16 at 09:56
Try moving the MyReceiver class to an independent file, rather than inside the service – Arun Shankar Mar 22 '16 at 09:59
And MainActivity.minochaDevicePolicyManager.resetPassword(str, 0); this line will throw exception when activity is destroyed. – Arun Shankar Mar 22 '16 at 10:01
then the receiver will stop working when the activity is destroyed! – AxeManTOBO Mar 22 '16 at 10:01
No. It will not. You are confusing between BroadcastManager and BroadcastReceiver. – Arun Shankar Mar 22 '16 at 10:02
And, will you please tell me what you are trying to achieve? Running a service every minute is what you want - in plain words? For that, why r you using a reciever? – Arun Shankar Mar 22 '16 at 10:08
i need the receiver to run even when the activity is destroyed. for that i need a service so that the receiver will run the whole time. When the trigger is set off by the alarm scheduler, it will execute the code inside the onReceive which is IN the service. – AxeManTOBO Mar 22 '16 at 10:10
My god! Why can't you run the service directly from the alarm manager? Why are you making thismuch complex? – Arun Shankar Mar 22 '16 at 10:11
Service will run even activity is destroyed. – Arun Shankar Mar 22 '16 at 10:12
yes, but when the service is running already, how is it possible to call the service which is already running – AxeManTOBO Mar 22 '16 at 10:14
and where do i put the code what i want to execute? – AxeManTOBO Mar 22 '16 at 10:15
Stop the service after execution by stopself! – Arun Shankar Mar 22 '16 at 10:15
Read that link I posted in the answer. Its same purpose as ura – Arun Shankar Mar 22 '16 at 10:16
@AxeManTOBO i added one more link, which will help you directly. – Arun Shankar Mar 22 '16 at 10:23
Please let us kbow whether that helped – Arun Shankar Mar 22 '16 at 10:24
Have you checked the second link? – Arun Shankar Mar 22 '16 at 10:29
The second link is only for when boot is complete right? so i first followed the first link only – AxeManTOBO Mar 22 '16 at 10:32
That boot is to rescheduling the AlarmManager automatically after rebooting – Arun Shankar Mar 22 '16 at 10:34
which method do i put my code i want to run? in the service – AxeManTOBO Mar 23 '16 at 06:45
OnCreate. Just like an activity – Arun Shankar Mar 23 '16 at 08:38
hey @DevTest. THe service gets created and the code is executed but its not periodic. – AxeManTOBO Mar 24 '16 at 03:43
means? not executed in intervals? Paste the code you used in your question – Arun Shankar Mar 24 '16 at 03:59
Fine. And you should check the design guidelines. Else you will encounter such instances again :-) Don't worry, I learned it the hard way, just like you I used to wrote so convoluted code, and experts here corrected my way :-) – Arun Shankar Mar 24 '16 at 04:12
Thanks a lot. Although theres a small bug in my app. Could you help me with that? Can we move this discussion to chat? – AxeManTOBO Mar 24 '16 at 04:42
Yes. Or you can start a new question, so that you may get better opinions from the seniors :-) – Arun Shankar Mar 24 '16 at 04:55

A broadcast receiver inside a service isnt working

3 Answers3