Show just one message box

Question

I'm trying to show just one message box using the gameover bool to control the situation but it doesn't work, its showing infinite message boxes.

bool player2turn = false;
bool gameover = false;


private void timer1_Tick(object sender, EventArgs e)
 {

  if ((pb00.BackColor == pb10.BackColor) && (gameover == false))
     {
       winner();               
     }


 }

private void winner()
 {

  if (player2turn == false)
     {
       MessageBox.Show("Player 2 wins!", "Retry?", MessageBoxButtons.YesNo);
       gameover = true;
      }
  else
      {
       MessageBox.Show("Player 1 wins!", "Retry?", MessageBoxButtons.YesNo);
       gameover = true;

      }

  }

You'll have to stop that timer, add timer1.Stop() *before* you display the message box. — Hans Passant, Mar 20 '16 at 20:55

score 0 · Accepted Answer · answered Mar 20 '16 at 21:00

MessageBox.Show blocks execution of the code until you close the message box, so you need to move the assignment of gameover before the call to MessageBox.Show.

private void winner()
 {

  if (player2turn == false)
     {
       gameover = true;
       MessageBox.Show("Player 2 wins!", "Retry?", MessageBoxButtons.YesNo);       
      }
  else
      {
       gameover = true;
       MessageBox.Show("Player 1 wins!", "Retry?", MessageBoxButtons.YesNo);       
      }
  }

score 0 · Answer 2 · answered Mar 20 '16 at 21:00

@HansPassant thank you

private void winner()
{

if (player2turn == false)
  {
   timer1.Stop();
   MessageBox.Show("Player 2 wins!", "Retry?", MessageBoxButtons.YesNo);
   gameover = true;
  }
else
  {
   timer1.Stop();
   MessageBox.Show("Player 1 wins!", "Retry?", MessageBoxButtons.YesNo);
   gameover = true;

  }

}

Show just one message box

2 Answers2