JSP Unterminated Tag With Nested OGNL

Question

I have some OGNL I am using to populate the href element of an <s:a> to a dynamically produced URL, handled by the Google UserService.

<%@ taglib prefix="s" uri="/struts-tags"%>
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>

<c:set var="requestUri" value="%{#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest'].requestURI}" />
<s:a href="%{#action.userService.createLoginURL("<c:out value="${requestUri}"/>");}">Sign in</s:a>

However, I am getting an error saying the <s:a> tag is unterminated. I have tried escaping inner speechmarks, and using single quotes but so far I have always been greeted with the same error message.

(11,71) Unterminated &lt;s:a tag

I can't for the life of me see what is wrong. Maybe someone with better eyes for the language will see something I cannot.

@AleksandrM Rolled back because OP is using Struts2 and OGNL. Don't close questions that I was answered, don't edit tags to remove relevant ones. — Roman C, Mar 22 '16 at 10:47
@RomanC Not S2 or OGNL related. Jsp tags cannot be nested like that. — Aleksandr M, Mar 22 '16 at 10:50
OP was using Struts2 tags, that doesn't work without struts2 — Roman C, Mar 22 '16 at 10:53
@AleksandrM Please stop rollback questions that I was answered. — Roman C, Mar 23 '16 at 12:55
@RomanC It is not about you. It is about question. No OGNL there and jsp tags cannot be nested like that. — Aleksandr M, Mar 23 '16 at 12:58
@AleksandrM %{#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest'].requestURI} not OGNL? — Roman C, Mar 23 '16 at 12:59
@AleksandrM it's a string, the second tag is `s:a` where OP was trying to use it. The title also shows that the question is using OGNL. — Roman C, Mar 23 '16 at 13:14
@RomanC Nested ognl? Maybe you should add info to your answer about where ognl can be used. — Aleksandr M, Mar 23 '16 at 13:17
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/107138/discussion-between-aleksandr-m-and-roman-c). — Aleksandr M, Mar 23 '16 at 13:25

score 1 · Accepted Answer · edited May 23 '17 at 11:45

1

You cannot use JSP tags in Struts tag's attributes, but you can use OGNL there.

Also note, that you can use OGNL only in Struts tag's attributes. And in most cases OGNL is executed once on the server, you shouldn't use nested OGNL or whatever you call it. May be this question will show you how to use you called nested OGNL.

<s:set var="requestUri" value="%{#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest'].requestURI}" />
<s:a href="%{#action.userService.createLoginURL(#requestUri)}">Sign in</s:a>

edited May 23 '17 at 11:45

Community

1
1

answered Mar 20 '16 at 21:14

Roman C

49,761
33
66
176

Thanks for the quick reply Roman :) This allowed me to compile and deploy, but the link is blank i.e not a hyperlink, just plain text in an tag. Any ideas what the problem could be here? – Sam Holden Mar 20 '16 at 21:32
Why it should be blank if the objects have appropriate getters? – Roman C Mar 21 '16 at 15:54

score 0 · Answer 2 · answered Mar 20 '16 at 21:14

0

Ah ok problem solved. Turns out the c:out wasn't needed to output the value of requestUri. It could simply be left as-is to be evaluated with the rest of the expression

answered Mar 20 '16 at 21:14

Sam Holden

105
1
7

JSP Unterminated Tag With Nested OGNL

2 Answers2

Linked

Related