Change selected view background color in Gallery view

Question

I want to change background color of selected view but after putting below code I got Error.

When user selected other view of gallery previous view come to default color but now I got below error

When I change selected item on gallery view error comes

gallery.setOnItemSelectedListener(new OnItemSelectedListener() {

        @SuppressLint("ResourceAsColor")
        @Override
        public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {
            // if(position != save)
            // parent.getChildAt(position).setBackgroundResource(R.drawable.state_selected);

            view.setBackgroundColor(Color.GREEN);
            if (save != -1) {
                parent.getChildAt(save).setBackgroundColor(Color.RED);
            }

            save = position;

        }

        @Override
        public void onNothingSelected(AdapterView<?> parent) {
            // TODO Auto-generated method stub

        }

    });

Log

java.lang.NullPointerException
    at com.example.csglobal.MainActivity$2.onItemSelected(MainActivity.java:119)
    at android.widget.AdapterView.fireOnSelected(AdapterView.java:892)
    at android.widget.AdapterView.selectionChanged(AdapterView.java:879)
    at android.widget.Gallery.selectionChanged(Gallery.java:546)
    at android.widget.AdapterView.checkSelectionChanged(AdapterView.java:1043)
    at android.widget.Gallery.setSelectionToCenterChild(Gallery.java:592)
    at android.widget.Gallery.trackMotionScroll(Gallery.java:396)
    at android.widget.Gallery$FlingRunnable.run(Gallery.java:1504)
    at android.os.Handler.handleCallback(Handler.java:615)
    at android.os.Handler.dispatchMessage(Handler.java:92)
    at android.os.Looper.loop(Looper.java:137)
    at android.app.ActivityThread.main(ActivityThread.java:4745)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:511)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
    at dalvik.system.NativeStart.main(Native Method)

please refer [try this link](http://stackoverflow.com/questions/2217753/changing-background-color-of-listview-items-on-android) this link — Yogesh Borhade, Mar 09 '16 at 04:59
Its is happening because getView method in your adapter changes back to default image. You need to change the imge in getview method of your adapter, then i won't change back to default image. — waqas ali, Mar 09 '16 at 05:24

User6006 · Answer 1 · 2016-03-09T05:58:43.930

It works fine for me, Try this one:-

MainActivity.java:-

public class MainActivity extends Activity {

            int save = -1;

Integer[] imageIDs = { R.drawable.pic1, R.drawable.pic2, R.drawable.pic3,
                    R.drawable.pic4, R.drawable.pic5, R.drawable.pic6, R.drawable.pic7 };

      @Override
       protected void onCreate(Bundle savedInstanceState) {
                super.onCreate(savedInstanceState);
                setContentView(R.layout.activity_main);

                // Note that Gallery view is deprecated in Android 4.1---
                Gallery gallery = (Gallery) findViewById(R.id.gallery1);
                gallery.setAdapter(new ImageAdapter(this));     

                gallery.setOnItemSelectedListener(new OnItemSelectedListener() {

                    @Override
                    public void onItemSelected(AdapterView<?> parent, View view,
                            int position, long id) {
                        // TODO Auto-generated method stub
                        view.setBackgroundColor(Color.GREEN);

                        if (save != -1) {
                            parent.getChildAt(save).setBackgroundColor(Color.RED);
                        }

                        save = position;
                    }
                    @Override
                    public void onNothingSelected(AdapterView<?> parent) {
                        // TODO Auto-generated method stub

                    }

                });
            }

public class ImageAdapter extends BaseAdapter {

private Context context; private int itemBackground;

  public ImageAdapter(Context c) {
                    context = c;
                    // sets a grey background; wraps around the images
                    TypedArray a = obtainStyledAttributes(R.styleable.MyGallery);
                    itemBackground = a.getResourceId(
                            R.styleable.MyGallery_android_galleryItemBackground, 0);
                    a.recycle();
                }

                // returns the number of images
                public int getCount() {
                    return imageIDs.length;
                }

                // returns the ID of an item
                public Object getItem(int position) {
                    return position;
                }

                // returns the ID of an item
                public long getItemId(int position) {
                    return position;
                }

                // returns an ImageView view
                public View getView(int position, View convertView, ViewGroup parent) {
                    ImageView imageView = new ImageView(context);
                    imageView.setImageResource(imageIDs[position]);
                    imageView.setLayoutParams(new Gallery.LayoutParams(100, 100));
                    imageView.setBackgroundResource(itemBackground);
                    return imageView;
                }
            }
        }

activity_main.xml:-

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
            xmlns:tools="http://schemas.android.com/tools"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            tools:context="${relativePackage}.${activityClass}"
            android:orientation="vertical" >

            <Gallery
                android:id="@+id/gallery1"
                android:layout_width="fill_parent"
                android:layout_height="wrap_content" />

            <ImageView
                android:id="@+id/image1"
                android:layout_width="215dp"
                android:layout_height="315dp"
                android:layout_gravity="center_horizontal"
                android:background="#cfcfcf"
                android:paddingTop="5dp"
                android:paddingBottom="5dp"
                android:paddingLeft="10dp"
                android:paddingRight="10dp"
                android:src="@drawable/pic1" />

        </LinearLayout>

In res->values->attrs.xml add following lines:-

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <declare-styleable name="MyGallery">
    <attr name="android:galleryItemBackground" />
    </declare-styleable>  
</resources>

what is obtainStyledAttributes? – Nirav Ranpara Mar 09 '16 at 05:34 — Nirav Ranpara, Mar 09 '16 at 05:34

Change selected view background color in Gallery view

1 Answers1