Getting errors while adding buttons to each item in a listview row

Question

OneFragment.java

package com.pixalstudio.musicadda;


import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ListView;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

public class OneFragment extends android.support.v4.app.Fragment {


    public OneFragment() {

    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        View view = inflater.inflate(R.layout.fragment_one, container, false);


        ArrayList<String> songs = new ArrayList<String>();

        List<String> Songs = Arrays.asList(getResources().getStringArray(R.array.songs));

//        list.add("item1");
//        list.add("item2");

        MyCustomAdapter adapter = new MyCustomAdapter(songs, getActivity());

        ListView listView = (ListView) view.findViewById(R.id.listView_fragone);
        listView.setAdapter(adapter);
        return view;
    }



    /*@Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        return inflater.inflate(R.layout.fragment_one, container, false);

        ArrayList<String> list = new ArrayList<String>();
        list.add("item1");
        list.add("item2");

        MyCustomAdapter adapter = new MyCustomAdapter(list, this);

        ListView listView = (ListView) getView().findViewById(R.id.listView_fragone);
        listView.setAdapter(adapter);
        return view;
    }*/


}

I am getting error on this file.

Error:(43, 13) error: <identifier> expected
Error:(43, 14) error: illegal start of type
Error:(44, 13) error: <identifier> expected
Error:(44, 14) error: illegal start of type
Error:(49, 24) error: <identifier> expected
Error:(49, 32) error: <identifier> expected

[This is FragmentOne.java where I am getting errors.]

MyCustomAdapter.java

    package com.pixalstudio.musicadda;

import android.content.Context;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.BaseAdapter;
import android.widget.Button;
import android.widget.ListAdapter;
import android.widget.TextView;

import java.util.ArrayList;

/**
 * Created by akkie on 3/7/2016.
 */
public class MyCustomAdapter extends BaseAdapter implements ListAdapter {

    private ArrayList<String> list = new ArrayList<String>();
    private Context context;

    public MyCustomAdapter(ArrayList<String> list, Context context) {

        this.list = list;
        this.context = context;

    }

    @Override
    public int getCount() {
        return list.size();
    }

    @Override
    public Object getItem(int pos) {
        return list.get(pos);
    }

    @Override
    public long getItemId(int pos) {
        return 0;
        //just return 0 if your list items do not have an Id variable.
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        View view = convertView;
        if (view == null) {
            LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            view = inflater.inflate(R.layout.cust_layout, null);
        }

        //Handle TextView and display string from your list
        TextView listItemText = (TextView)view.findViewById(R.id.list_item_string);
        listItemText.setText(list.get(position));

        //Handle buttons and add onClickListeners
        Button deleteBtn = (Button)view.findViewById(R.id.delete_btn);
        Button addBtn = (Button)view.findViewById(R.id.add_btn);

        deleteBtn.setOnClickListener(new View.OnClickListener(){
            @Override
            public void onClick(View v) {
                //do something
                list.remove(position); //or some other task
                notifyDataSetChanged();
            }
        });
        addBtn.setOnClickListener(new View.OnClickListener(){
            @Override
            public void onClick(View v) {
                //do something
                notifyDataSetChanged();
            }
        });

        return view;
    }
}

Added MyCustomAdapter.java please check it and let me know if there changes need to be made.

you are passing this to MyCustomerAdapter which is current fragment not the Activity context, please change this to getActivity(). — Rohit Patil, Mar 07 '16 at 17:45
Thankx.. this solved the problem n the app perfectly. but now the problem is I dont want item1 & item2 list the listview, instead I have my own String array which I want to be displayed in the Listview. — akkie4396, Mar 07 '16 at 17:52
ArrayList list = Arrays.asList(getResources().getStringArray(R.array.list)); — Rohit Patil, Mar 07 '16 at 18:11

Vasily Kabunov · Answer 1 · 2016-03-07T17:33:14.617

2

Try to place your code inside onCreateView method.

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {

...

    ArrayList<String> list = new ArrayList<String>();
    list.add("item1");
    list.add("item2");

    MyCustomAdapter adapter = new MyCustomAdapter(list, this);

    ListView listView = (ListView) getView().findViewById(R.id.listView_fragone);
   listView.setAdapter(adapter);

...
}

edited Mar 07 '16 at 17:33

answered Mar 07 '16 at 17:31

Vasily Kabunov

6,511
13
49
53

Okay it solved one error.. but still showing error at MyCustomAdapter adapter = new MyCustomAdapter(list, this); .. – akkie4396 Mar 07 '16 at 17:33
MyCustomAdapter.java added above. please check. – akkie4396 Mar 07 '16 at 17:36
Cannot add logcat cause it does not even let me build the project.. so cannot run it. – akkie4396 Mar 07 '16 at 17:40
Try `MyCustomAdapter adapter = new MyCustomAdapter(list, getActivity());` – Vasily Kabunov Mar 07 '16 at 17:43
Thankx.. this solved the problem n the app perfectly. but now the problem is I dont want item1 & item2 list the listview, instead I have my own String array which I want to be displayed in the Listview. – akkie4396 Mar 07 '16 at 17:51
http://stackoverflow.com/questions/19127071/change-string-array-in-strings-xml-to-arraylist – Vasily Kabunov Mar 07 '16 at 17:53
hey i tried the tutotial from the link.. but now my listview does not show any data.. its blank.. – akkie4396 Mar 07 '16 at 18:31
I am adding new FragmentOne.java which I have edited. Please check if there is anything wrong. – akkie4396 Mar 07 '16 at 18:44
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/105602/discussion-between-akkie4396-and-vasily-kabunov). – akkie4396 Mar 07 '16 at 20:24

Rohit Patil · Answer 2 · 2016-03-07T19:33:43.077

1

you are passing this to MyCustomerAdapter which is current fragment not the Activity context, please change this to getActivity()

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    // Inflate the layout for this fragment
    View view = inflater.inflate(R.layout.fragment_one, container, false);

    ArrayList<String> Songs = Arrays.asList(getResources().getStringArray(R.array.songs));

   //        list.add("item1");
   //        list.add("item2");

    MyCustomAdapter adapter = new MyCustomAdapter(Songs , getActivity());

    ListView listView = (ListView) view.findViewById(R.id.listView_fragone);
    listView.setAdapter(adapter);
    return view;
}

edited Mar 07 '16 at 19:33

answered Mar 07 '16 at 17:33

Rohit Patil

1,068
8
9

I am adding new FragmentOne.java which I have edited. Please check if there is anything wrong. – – akkie4396 Mar 07 '16 at 18:45
List Songs = Arrays.asList(getResources().getStringArray(R.array.songs)); you are passing value Songs and for adapter you are assigning songs MyCustomAdapter adapter = new MyCustomAdapter(songs, getActivity()); – Rohit Patil Mar 07 '16 at 19:17
change to MyCustomAdapter adapter = new MyCustomAdapter(Songs, getActivity()); – Rohit Patil Mar 07 '16 at 19:18
Sorry but it does not work.. I am adding a snapshot of the Fragmentone.java file.. please let me know if I have made necessary changes. – akkie4396 Mar 07 '16 at 19:29
change List to ArrayList – Rohit Patil Mar 07 '16 at 19:33
ArrayList Songs = Arrays.asList(getResources().getStringArray(R.array.songs)); – Rohit Patil Mar 07 '16 at 19:34
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/105597/discussion-between-akkie4396-and-rohit-patil). – akkie4396 Mar 07 '16 at 19:52

Getting errors while adding buttons to each item in a listview row

2 Answers2