PHP array not inserting multiple rows to database

Question

I have created complex form, I'll try to provide simplified examples. There are ability to generate more fields by clicking + button.

For example in form are fields:

Certificate    Date Of Issue    Date of Expire   
[         ]    [           ]    [            ]   +

by clicking + button It add duplicate row (via javascript) so after clicking + button part of form looks like:

NameOfVessel    TypeOfVessel       YearBuilt  
[          ]    [           ]    [            ]

NameOfVessel    TypeOfVessel       YearBuilt  
[          ]    [           ]    [            ]   +

There are ability to click + button as many times as user needs.

I have HTML form like this:

<li>
    <ul class="column">         
        <li>
            <label for="NameOfVessel">Name of Vessel</label>
            <input id="NameOfVessel" type="text" name="NameOfVessel[]" class="field-style field-split25 align-left" placeholder="Name of Vessel" /> 
        </li>
    </ul>
</li>
<li>
    <ul class="column">         
        <li>
            <label for="TypeOfVessel">Type of Vessel</label>
            <input id="TypeOfVessel" type="text" name="TypeOfVessel[]" class="field-style field-split25 align-left" placeholder="Type of Vessel" /> 
        </li>           
    </ul>
</li>
<li>
    <ul class="column">         
        <li>
            <label for="YearBuilt">Year Built</label>
            <input id="YearBuilt" type="text" name="YearBuilt[]" class="field-style field-split25 align-left" placeholder="Year Built" />   
        </li>           
    </ul>
</li>

PHP to insert to database. It should insert values from all added rows to multiple database table's rows, but for now it not inserting anything.

$UserID = get_current_user_id();
$NameOfVessel = mysqli_real_escape_string($link, $_POST['NameOfVessel']);       
$TypeOfVessel = mysqli_real_escape_string($link, $_POST['TypeOfVessel']);       
$YearBuilt = mysqli_real_escape_string($link, $_POST['YearBuilt']); 

foreach($NameOfVessel as $key=>$res) {
    $sql2 = "INSERT INTO CV_SeaServices (NameOfVessel, UserId, TypeOfVessel, YearBuilt) VALUES ('$res', '$UserId[$key]', '$TypeOfVessel[$key]', '$YearBuilt[$key]')";
    if(mysqli_query($link, $sql2)){
        echo "Resume created successfully.";
    } else {
        echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);
    }
}
var_dump($NameOfVessel);

I've used var_dump, but it returning NULL. What's wrong with this code? Have you any ideas?

UPDATE

I've tried to do in following:

JS:

var noOfClicks = 0;
$(document).ready(function() {
    $(".add-row").click(function() {
        $("ul.sea-service").first().clone().appendTo(".personal-details1").append('<button class="remove">X</button>').find('input').val('');
        noOfClicks += 1;

    });
    $("body").on('click', '.remove', function() {
        $(this).closest('.sea-service').remove();
    });
});

HTML:

<input id="NameOfVessel' + noOfClicks + '" type="text" name="NameOfVessel[]" class="field-style field-split25 align-left" placeholder="Name of Vessel" />

But in this case I got Id = ' + 'NameOfVessel' + noOfClicks + '. As I understood I need to do that concatenation via javascript, just I can't achieve It correctly.

So - you probably have an issue with your mysqli link / connection? What do you get when you `var_dump($_POST['NameOfVessel'])`? — random_user_name, Mar 05 '16 at 14:38

score 4 · Accepted Answer · edited May 23 '17 at 12:07

4

string mysqli_real_escape_string ( mysqli $link , string $escapestr )

(docs)

mysqli_real_escape_string expects a string, not an array.

You should first loop the $_POST['NameOfVessel'] array and apply mysqli_real_escape_string on the values. Same goes for the other post keys.

Assuming that $_POST['NameOfVessel'], $_POST['TypeOfVessel'] and $_POST['YearBuilt'] have the same number of elements, you can do something like:

$userId = $UserId[$key]; // because you're overriding `$key` below.
foreach($_POST['NameOfVessel'] as $key => $val){
    $NameOfVessel = $val;
    $TypeOfVessel = $_POST['TypeOfVessel'][$key];
    $YearBuilt    = $_POST['YearBuilt'][$key];

    $NameOfVessel = mysqli_real_escape_string($link, $NameOfVessel); 
    $TypeOfVessel = mysqli_real_escape_string($link, $TypeOfVessel); 
    $YearBuilt    = mysqli_real_escape_string($link, $YearBuilt); 

    $sql2 = "INSERT INTO CV_SeaServices 
            (NameOfVessel, UserId, TypeOfVessel, YearBuilt) 
            VALUES 
            ('$res', '$userId', '$TypeOfVessel', '$YearBuilt')";

    if(mysqli_query($link, $sql2)){
        echo "Resume created successfully.";
    } else {
        echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);
    }
}

To achieve uniqueness of IDs after cloning, see this answer: jQuery clone and change Ids.

It requires some adapting. Maybe it's easier to remove the id's altogether.

edited May 23 '17 at 12:07

Community

1
1

answered Mar 05 '16 at 14:42

Alex Tartan

6,736
10
34
45

Thank you for an answer, but It a little bit unclear for me, how should I use loop with `$_POST['NameOfVessel']` correctly? – Infinity Mar 05 '16 at 14:45
Thank you this almost working. By clicking `+` button adding multiple fields, also `` drop-down list are added but from drop down list only from first row value inserting. Have you ideas why? – Infinity Mar 05 '16 at 15:49
Your ids are not unique. Just noticed this: `id="NameOfVessel"` and if you have that repeated for each line, in conjunction with an AJAX call that sends them by id, you get overlapping values. Make sure your id's are unique :) – Alex Tartan Mar 05 '16 at 19:11
Thank you for an answer, but how could I achieve that all id's became unique? – Infinity Mar 06 '16 at 11:45
You can have a js variable like `var noOfClicks = 0;` and increment it on "add row" button (or whatever it's called). Set you initial id's to `NameOfVessel0` (and all the others too). In you `javascript duplication`, just concatenate something like `id="' + 'NameOfVessel' + noOfClicks + '"'` instead of `id="NameOfVessel"` – Alex Tartan Mar 06 '16 at 11:51

PHP array not inserting multiple rows to database

1 Answers1