OnCreate expected semicolon in Android studio

Question

    public class MainActivity extends AppCompatActivity {
        private TaskDBHelper helper;
        private ListAdapter listAdapter;
        @Override
        public void onCreate(Bundle savedInstanceState) {

            private void updateUI(){
                helper = new TaskDBHelper(MainActivity.this);
                SQLiteDatabase sqlDB = helper.getReadableDatabase();
                Cursor cursor = sqlDB.query(TaskContract.TABLE,
                        new String[]{TaskContract.Columns._ID, TaskContract.Columns.TASK},
                        null, null, null, null, null);

                listAdapter = new SimpleCursorAdapter(
                        this,
                        R.layout.task_view,
                        cursor,
                        new String[]{TaskContract.Columns.TASK},
                        new int[]{R.id.taskTextView},
                        0
                );
                ListView listView = (ListView) findViewById(R.id.list);
                listView.setAdapter(listAdapter);
            }
        }
}

I keep getting a red mark on private void updateUI() where an error message that displays express expected (semicolon).

You are calling a method inside method – Zaki Mar 01 '16 at 14:07 — Zaki, Mar 01 '16 at 14:07
updateUi method implement in oncreate method – Khizar Hayat Mar 01 '16 at 14:10 — Khizar Hayat, Mar 01 '16 at 14:10

Zaki · Accepted Answer · 2016-03-01T14:12:25.700

Try this:

 public class MainActivity extends AppCompatActivity {
        private TaskDBHelper helper;
        private ListAdapter listAdapter;
        @Override
        public void onCreate(Bundle savedInstanceState) {
                super.onCreate(savedInstanceState);
                updateUI();
                ListView listView = (ListView) findViewById(R.id.list);
                listView.setAdapter(listAdapter);
            }

            private void updateUI(){
                helper = new TaskDBHelper(MainActivity.this);
                SQLiteDatabase sqlDB = helper.getReadableDatabase();
                Cursor cursor = sqlDB.query(TaskContract.TABLE,
                        new String[]{TaskContract.Columns._ID, TaskContract.Columns.TASK},
                        null, null, null, null, null);

                listAdapter = new SimpleCursorAdapter(
                        this,
                        R.layout.task_view,
                        cursor,
                        new String[]{TaskContract.Columns.TASK},
                        new int[]{R.id.taskTextView},
                        0
                );
        }
}

updated it. add this line : super.onCreate(savedInstanceState); btw you need to set your your layout too after onCreate: setContentView(R.layout.YOUR_ACTIVITY); — Zaki, Mar 01 '16 at 14:12

score 2 · Answer 2 · answered Mar 01 '16 at 14:22

2

In Java you can't declare a method inside scope of another method. You can only declare methods inside scope of a class. So your way of declaring the method updateUI() is invalid and should be moved to the class scope.

answered Mar 01 '16 at 14:22

frogatto

28,539
11
83
129

OnCreate expected semicolon in Android studio

2 Answers2