Use andWhere under IF condition in Yii2

Question

Just a quick question. I need to create a find query in Yii2 where an andWhere is only present if a variable is true.

public function getCheckBoxItems($holiday=false)
{
    $Items = Items::find()->where(['type'=>'checkbox']);
    Yii::info(print_r($Items,1), 'c');

    if($holiday)
        $Items->andWhere(['<>','category','holiday']);

    $Items->All();
    foreach($Items as $Item)
    {
        //do something
    }
}

This doesn't work

However this deos work and i expected it to.

$Items = Items::find()->where(['type'=>'checkbox'])->andWhere(['<>','category','holiday'])->All();

How do I only add the andWhere based on the $holiday variable

Thanks in advance

Regards

Liam

UPDATE i have found one way, but i am sure there is a better way

    if($holiday)
        $Items = Items::find()->where(['type'=>'checkbox'])->andWhere(['<>','category','holiday'])->All();
    else            
        $Items = Items::find()->where(['type'=>'checkbox'])->All();

use only `andWhere()` in both. – Insane Skull Feb 19 '16 at 11:52 — Insane Skull, Feb 19 '16 at 11:52
But i only what the andWhere if $holiday is true – Liam Feb 19 '16 at 12:09 — Liam, Feb 19 '16 at 12:09
it work both ways, $holiday is true or false. – Insane Skull Feb 19 '16 at 12:10 — Insane Skull, Feb 19 '16 at 12:10
This should be `$Items = $Items->All();`... – soju Feb 19 '16 at 12:55 — soju, Feb 19 '16 at 12:55

score 7 · Answer 1 · answered Feb 19 '16 at 12:54

Just to make your code more clear and readable, you should simply try :

$itemsQuery = Items::find()->where(['type'=>'checkbox']);

if($holiday)
    $itemsQuery->andWhere(['<>','category','holiday']);

$items = $itemsQuery->all();
foreach($items as $item)
{
    //do something
}

Insane Skull · Answer 2 · 2016-02-19T13:02:56.980

2

You have to store $items result at each checkpoint:

public function getCheckBoxItems($holiday=false)
{
$Items = Items::find()->where(['type'=>'checkbox']);
Yii::info(print_r($Items,1), 'c');

if($holiday)
    $Items->andWhere(['<>','category','holiday']);

$Items = $Items->All();
foreach($Items as $Item)
{
    //do something
}
}

edited Feb 19 '16 at 13:02

answered Feb 19 '16 at 12:34

Insane Skull

9,220
9
44
63

You don't need `$Items = $Items->andWhere(['<>','category','holiday']);` – soju Feb 19 '16 at 12:57

Use andWhere under IF condition in Yii2

2 Answers2