Cardview click event is not working on android?

Question

I show list of data in card view successfully but now i want to open another activity and show details of clicked data.

I have three class MainActivity, ContactAdapter, Contact.

Main Activity Code:

RecyclerView recyclerView;
RecyclerView.Adapter adapter;
RecyclerView.LayoutManager layoutManager;
String[] name,email;
ArrayList<Contact> list = new ArrayList<Contact>();
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
    setSupportActionBar(toolbar);

    name = getResources().getStringArray(R.array.person_name);
    email = getResources().getStringArray(R.array.person_email);

    int count = 0;
    for (String Name : name)
    {
        Contact contact = new Contact(Name,email[count]);
        count++;
        list.add(contact);
    }
    recyclerView= (RecyclerView) findViewById(R.id.recycler_view);
    layoutManager = new LinearLayoutManager(this);
    recyclerView.setLayoutManager(layoutManager);
    recyclerView.setHasFixedSize(true);
    adapter=new ContactAdapter(list);
    recyclerView.setAdapter(adapter);

i tried but it's not working.

Adapter Code:

public class ContactAdapter extends RecyclerView.Adapter<ContactAdapter.ContactViewHolder> {
    ArrayList<Contact> contacts = new ArrayList<Contact>();

    public ContactAdapter(ArrayList<Contact> contacts) {
        this.contacts = contacts;
    }

    @Override
    public ContactViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.card_view_layout, parent, false);
        ContactViewHolder contactViewHolder = new ContactViewHolder(view);
        return contactViewHolder;
    }

    @Override
    public void onBindViewHolder(ContactViewHolder holder, int position) {
        Contact CON = contacts.get(position);
        holder.person_name.setText(CON.getName());
        holder.person_email.setText(CON.getEmail());
    }

    @Override
    public int getItemCount() {
        return contacts.size();
    }

    public static class ContactViewHolder extends RecyclerView.ViewHolder {
        TextView person_name, person_email;

        public ContactViewHolder(View view) {
            super(view);
            person_name = (TextView) view.findViewById(R.id.person_name);
            person_email = (TextView) view.findViewById(R.id.person_email);

            view.setOnClickListener(new View.OnClickListener() {

                @Override
                public void onClick(View v) {

                    Toast.makeText(v.getContext(), "OnClick Version :",
                            Toast.LENGTH_SHORT).show();
                }
            });

            view.setOnLongClickListener(new View.OnLongClickListener() {

                @Override
                public boolean onLongClick(View v) {

                    Toast.makeText(v.getContext(), "OnLongClick Version :",
                            Toast.LENGTH_SHORT).show();
                    return true;

                }
            });
        }
    }
}

See if the onClick is getting called by placing a Log inside it. — Shashank Udupa, Feb 17 '16 at 12:06
A Toast should work if on Click works, a Log is not necessary... — Opiatefuchs, Feb 17 '16 at 12:07
I meant this to the comment of Shashank Udupa. If the toast is not working, then onClick is not working. I think the problem here is the onBind method: http://stackoverflow.com/questions/27081787/onclicklistener-for-cardview — Opiatefuchs, Feb 17 '16 at 12:12

score 0 · Answer 1 · answered Feb 17 '16 at 12:11

In your adapter do this:

    public class ProdutoAdapter extends RecyclerView.Adapter<ProdutoAdapter.ProdutoViewHolder>{
    private static ProdutoAdapter.ClickListener clickListener; //this is important
    private List<Produto> produtos; //this is my list of beans

    public ProdutoAdapter(List<Produto> produtos) {
        this.produtos = produtos;
    }

    @Override
    public ProdutoViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        View v = LayoutInflater.from(parent.getContext()).inflate(R.layout.cardview_produtos, parent, false);
        ProdutoViewHolder mvh = new ProdutoViewHolder(v);
        return mvh;
    }

    @Override
    public void onBindViewHolder(ProdutoViewHolder holder, int position) {
        //holder.nome.setText(this.produtos.get(position).getNome());
        holder.img.setImageDrawable(produtos.get(position).getImgDrawable());
        holder.nome.setText(produtos.get(position).getNome());
        holder.preco.setText(String.valueOf(produtos.get(position).getPreco()));
    }

    @Override
    public int getItemCount() {
        return this.produtos.size();
    }

    @Override
    public void onAttachedToRecyclerView(RecyclerView recyclerView) {
        super.onAttachedToRecyclerView(recyclerView);
    }

    public static class ProdutoViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener, View.OnLongClickListener{
        Produto produto;
        CardView cardView;
        TextView nome;
        TextView preco;
        ImageView img;

        ProdutoViewHolder(View itemView) {
            super(itemView);
            itemView.setOnClickListener(this);
            itemView.setOnLongClickListener(this);
            cardView = (CardView) itemView.findViewById(R.id.cardviewProduto);
            nome = (TextView) itemView.findViewById(R.id.nome);
            preco = (TextView) itemView.findViewById(R.id.preco);
            img = (ImageView) itemView.findViewById(R.id.foto);
        }

        public void setItem(Produto produto){
            this.produto = produto;
        }

        public Produto getItem(){
            return this.produto;
        }

//this is what you'll need in your activity
        @Override
        public void onClick(View v) {
            clickListener.onItemClick(getAdapterPosition(), v);
        }

        @Override
        public boolean onLongClick(View v) {
            clickListener.onItemLongClick(getAdapterPosition(), v);
            return false;
        }
    }

    public void setOnItemClickListener(ClickListener clickListener){
        ProdutoAdapter.clickListener = clickListener;
    }

    public interface ClickListener {
        void onItemClick(int position, View v);
        void onItemLongClick(int position, View v);
    }

}

and in your activity:

    public static ProdutoAdapter mAdapter;
myActivity.mAdapter.setOnItemClickListener(new ProdutoAdapter.ClickListener() {
                @Override
                public void onItemClick(int position, View v) {
//do what you want
                }

                @Override
                public void onItemLongClick(int position, View v) {

                }
            });
            myActivity.mRecyclerView.setAdapter(mAdapter);

Cardview click event is not working on android?

1 Answers1