Listview Items Repeated android

Question

This is my Code for retrieving Data from a server, and the listview is called each time. and the items are repeated if anyone can help me with appending or something

My Code :

package NewsTabFragment;

import android.app.Activity;
import android.content.Context;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.BaseAdapter;
import android.widget.TextView;

import com.android.volley.toolbox.ImageLoader;
import com.android.volley.toolbox.NetworkImageView;
import com.subhi.tabhost.AppController;
import com.subhi.tabhost.R;

import java.util.List;

/**
 * Created by tb_laota on 9/21/2015.
 */
public class Adapter extends BaseAdapter{
    private LayoutInflater inflater;
    private Activity activity;
    private List<Item> items;

    ImageLoader imageLoader= AppController.getmInstance().getmImageLoader();

    public Adapter(Activity activity,List<Item> items){
        this.activity=activity;
        this.items=items;
    }
    @Override
    public int getCount() {
        return items.size();
    }

    @Override
    public Object getItem(int position) {
        return items.get(position);
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        if(inflater==null){
            inflater=(LayoutInflater) activity.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        }
        if(convertView ==null){
            convertView=inflater.inflate(R.layout.custom_layout,null);


        }
        if(imageLoader==null)
            imageLoader=AppController.getmInstance().getmImageLoader();


        NetworkImageView imageView= (NetworkImageView) convertView.findViewById(R.id.image_view);

        TextView news_title=(TextView)convertView.findViewById(R.id.news_title);
        TextView news_text= (TextView) convertView.findViewById(R.id.news_text);
        // TextView url= (TextView) convertView.findViewById(R.id.url);
        TextView time_stamp= (TextView) convertView.findViewById(R.id.time_stamp);
        TextView news_url= (TextView) convertView.findViewById(R.id.news_url);


        //getting data for row

            Item item=items.get(position);

            imageView.setImageUrl(item.getImage(), imageLoader);

        news_text.setText(item.getNews_text());
        news_url.setText(item.getUrl());
        time_stamp.setText(item.getTime_stamp());
        news_title.setText(item.getNews_title());


        return convertView;
    }
}

I had seen some of Tutorials and Blogs on the Internet but nothing Works for me.

can you post the code where you fill the list with the data from the server? — Vasileios Pallas, Feb 16 '16 at 16:04
no the list is dynamic i am retrieving it from a server for news — Subhi, Feb 16 '16 at 16:06
please post the code where you fill the list, and where you initialize the Adapter — Vasileios Pallas, Feb 16 '16 at 16:07

score 3 · Accepted Answer · answered Feb 16 '16 at 16:17

Do the Following:

public class Adapter extends BaseAdapter{
    private LayoutInflater inflater;
    private Activity activity;
    private List<Item> items;

    ImageLoader imageLoader= AppController.getmInstance().getmImageLoader();

    /* Create a class which contains view elements */
    static class Holder{
        NetworkImageView imageView;
        TextView news_title;
        TextView news_text;
        TextView news_url
        TextView time_stamp
    }

    public Adapter(Activity activity,List<Item> items){
        this.activity=activity;
        this.items=items;
    }


    /* Helper method to use, when updating the list */
    public void updateItems(List<Item> items){
       if(items != null){
          // Either clear the list, or do some logic for skipping duplicates
          this.items.clear();
          this.items.addAll(items);
       }
       notifyDataSetChanged();
    }

    @Override
    public int getCount() {
        return items.size();
    }

    @Override
    public Object getItem(int position) {
        return items.get(position);
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        Holder rowHolder;
        if(convertView ==null){
            convertView = LayoutInflater.from(activity).inflate(R.layout.custom_layout,null);
           rowHolder = new Holder();
           rowHolder.imageView = (NetworkImageView) convertView.findViewById(R.id.image_view); 
           rowHolder.news_title =(TextView)convertView.findViewById(R.id.news_title);
           rowHolder.news_text= (TextView) convertView.findViewById(R.id.news_text);
           rowHolder.time_stamp= (TextView) convertView.findViewById(R.id.time_stamp);
           rowHolder.news_url= (TextView) convertView.findViewById(R.id.news_url);

           // tell convertView to set its Tag to the Holder object
           convertView.setTag(rowHolder);
        }else{
          // for recycling
            holder = (Holder) convertView.getTag();
        }

        if(imageLoader==null)
            imageLoader = AppController.getmInstance().getmImageLoader();


        //getting data for row
        final Item item = items.get(position);

        // null check the item
        if(item != null){
            holder.imageView.setImageUrl(item.getImage(), imageLoader);
            holder.news_text.setText(item.getNews_text());
            holder.news_url.setText(item.getUrl());
            holder.time_stamp.setText(item.getTime_stamp());
            holder.news_title.setText(item.getNews_title());
        }

        return convertView;
    }
}

then when you get new data from the server just call:

 mAdapter.updateItems(mItems);

where mItems is List you retrieved from the server

score 1 · Answer 2 · answered Feb 16 '16 at 16:14

1

You may be adding the objects after every time the WebService is called. Just Clear the array before adding newer objects to the ArrayList.

answered Feb 16 '16 at 16:14

Chandan kushwaha

941
6
26

Listview Items Repeated android

2 Answers2