Why doesn't this code work? FizzBuzz JAVA

Question

I cant get "FizzBuzz". No matter what the input, the "FizzBuzz" code isn't running. What did I do wrong?

public String[] fizzBuzz(int start, int end) {

int diff = end-start;
String[] array = new String[diff];

for (int i = 0; i < diff; i++) {
    if (start%3 == 0 && start%5 == 0) array[i] = "FizzBuzz";
    if (start%3 == 0 || start%5 == 0) {
        if (start%3 == 0) array[i] = "Fizz";
        if (start%5 == 0) array[i] = "Buzz";
    }
    else {
        array[i] = String.valueOf(start);
    }
    start++;
    }

    return array;
}

Your second `if` should be an `else if` (because when both are true, either is also true). — Elliott Frisch, Feb 13 '16 at 20:55

score 1 · Accepted Answer · answered Feb 13 '16 at 20:48

Logic in your if statements is a bit busted, using your code as the starting point, you'd have to do something like this.

if (start%3 == 0 && start%5 == 0) {
    array[i] = "FizzBuzz";
}
else if (start%3 == 0 || start%5 == 0) {
    if (start%3 == 0) array[i] = "Fizz";
    if (start%5 == 0) array[i] = "Buzz";
}
else {
    array[i] = String.valueOf(start);
}

score 0 · Answer 2 · answered Oct 10 '18 at 17:46

0

String s = "" + i;
if ((i % 3) == 0) {
    s += " Fizz";
}
if ((i % 5) == 0) {
    s+= " Buzz";
}
System.out.println(s);

This code snippet placed in a loop will print Fizz, Buzz and Fizz Buzz on i divisible by 3, 5 and 15 respectively.

answered Oct 10 '18 at 17:46

JohnCanessa

39
6

score 0 · Answer 3 · answered Apr 10 '19 at 06:40

0

you should try this.

    class FizzBuzz{
    public static void main(String args[]){
        int n = 100;
        for(int i=0;i<=n;i++){

            if((i % 3) == 0 && (i % 5) != 0){
                 System.out.println("Fizz");
            }
            else if((i % 5) == 0 && (i % 3) != 0){
                System.out.println("Buzz");
            }else if((i % 3) == 0 && (i % 5) == 0){
                System.out.println("FizzBuzz");
            }else{
                System.out.println(""+i);
            }

        }
    }
}

answered Apr 10 '19 at 06:40

sachinsuthariya

435
7
11

Nice code, but I can't figure the detail why it doesn't fail. Can you edit the answer and add a description? – Nomce Apr 10 '19 at 07:05
Sorry, my friend i didn't get your point. does you ask me to explain the code. OR In which term i should have to add description. – sachinsuthariya Apr 10 '19 at 13:08

Why doesn't this code work? FizzBuzz JAVA

3 Answers3