12

I want to render JSON with the following cors header in my controller:

'Access-Control-Allow-Origin' = '*'.

I tried this:

def my_action
  render(json: some_params)
  response.headers['Access-Control-Allow-Origin'] = '*'
end

but I got an AbstractController::DoubleRenderError. Are there ways to render JSON with headers?

sawa
  • 165,429
  • 45
  • 277
  • 381
Ilya
  • 13,337
  • 5
  • 37
  • 53

2 Answers2

28

You can't set a header after render, because the response is sent. So change the headers after makes no sense and you get this error.

Try:

def my_action
  response.headers['Access-Control-Allow-Origin'] = '*'
  render(json: some_params)
end

UPDATE FOR RAILS 5

As pointed in the question How do you add a custom http header?, after rails 5 you should be setting the headers as following:

response.set_header('HEADER NAME', 'HEADER VALUE')
Hector Acosta
  • 198
  • 1
  • 6
guitarman
  • 3,290
  • 1
  • 17
  • 27
4

The issue here is that you are rendering the response and then sending the headers.
You should never set headers after the response is sent.

render should be, usually, the last line of your action.

def my_action
  ...
  response.headers['Access-Control-Allow-Origin'] = '*'
  render json: some_params
end
Mihai Dinculescu
  • 19,743
  • 8
  • 55
  • 70