please suggest me the best practice in sting-value formating

Question

i have a long string like below which i m trying to format aswel aligning it with PEP standards

'http://abc/api/run=1&'+ \
            'actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"},{"query":"hotels-{1}-{3}-{4}-1-1_0-"},{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}]'+ \
            '&tripOrigin={0}&tripDestination={1}'.format(origin.get('vcid'), destination.get('vcid'), onward_f_date, check_in_date, check_out_date, return_f_date)

But ran in to output like be this

'http://abc/api/run=1&actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"},{"query":"hotels-{1}-{3}-{4}-1-1_0-"},{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}]&tripOrigin=2311443&tripDestination=123445667'

expecting formatting happen all the {0}, {1}, {2}, {3}, {4} and {5}

score 1 · Answer 1 · answered Feb 04 '16 at 11:15

1

Don't use concatenation: use the implicit joining that happens inside parentheses.

my_string = (
    'http://abc/api/run=1&'
    'actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"},{"query":"hotels-{1}-{3}-{4}-1-1_0-"},{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}]'
    '&tripOrigin={0}&tripDestination={1}'.format(origin.get('vcid'), destination.get('vcid'), onward_f_date, check_in_date, check_out_date, return_f_date)
)

answered Feb 04 '16 at 11:15

Daniel Roseman

588,541
66
880
895

hi @Daniel : ending up with this error KeyError: '"query"' – Arun G Feb 04 '16 at 11:26

score 1 · Answer 2 · answered Feb 04 '16 at 11:17

Surround your string with parentheses, you also won't need the + and \ anymore:

('http://abc/api/run=1&'
 'actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"},{"query":"hotels-{1}-{3}-{4}-1-1_0-"},{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}]'
 '&tripOrigin={0}&tripDestination={1}').format(origin.get('vcid'), destination.get('vcid'), onward_f_date, check_in_date, check_out_date, return_f_date)

score 1 · Accepted Answer · answered Feb 04 '16 at 11:21

You need to escape the curly braces that don't correspond to formatting placeholders.

Eg: This

'actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"}

Should look like:

'actionData=[{{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"}}

So:

>>> print 'http://abc/api/run=1&actionData=[{{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"}},{{"query":"hotels-{1}-{3}-{4}-1-1_0-"}},{{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}}]&
tripOrigin={0}&tripDestination={1}'.format(999,999,999,999,999,999)

http://abc/api/run=1&actionData=[{"query":"air-999-999-999--1-0-0-E-111--"},{"query":"hotels-999-999-999-1-1_0-"},{"query":"air-999-999-999--1-0-0-E-111--"}]&tripOrigin=999&tripDestination=999

score 1 · Answer 4 · answered Feb 04 '16 at 11:22

my_string = (
    'http://abc/api/run=1&'
    'actionData=[{"query":"air-{0}-{1}-{2}--1-0-0-E-111--"},'
    '{"query":"hotels-{1}-{3}-{4}-1-1_0-"},'
    '{"query":"air-{1}-{0}-{5}--1-0-0-E-111--"}]'
    '&tripOrigin={0}&tripDestination={1}'
).format(origin.get('vcid'), destination.get('vcid'),
         onward_f_date, check_in_date, check_out_date, return_f_date)

please suggest me the best practice in sting-value formating

4 Answers4