filling matrix with user's input in C#

Question

i wanna fill a matrix in C# with user's inputs,but i have trouble with it.when i enter rows and cols equal with each other,it work; but when i enter rows and cols different with each other the program stop . the code is

        int row = 0;
        int col = 0;
        int[,] matrix1;

        row = Convert.ToInt16(Console.ReadLine());
        col = Convert.ToInt16(Console.ReadLine());
        matrix1=new int[row,col];
        Console.WriteLine("enter the numbers");
        for (int i = 0; i < row; i++)
        {
            for (int j = 0; j < col; j++)
            {

                matrix1[i, j] = Convert.ToInt16(Console.ReadLine());// i have problem with this line,... plz show me the correct form

            }
        }

Add matrix1=new int[row,col]; after getting the values of row and col from the user not before as you have done — Razack, Jan 16 '16 at 05:53

score 1 · Answer 1 · answered Jan 16 '16 at 05:54

You allocate memory before you input array size. Correct code:

int row = 0;
int col = 0;
int[ , ] matrix1;

row = Convert.ToInt16( Console.ReadLine( ) );
col = Convert.ToInt16( Console.ReadLine( ) );
matrix1 = new int[ row, col ];
Console.WriteLine( "enter the numbers" );
for ( int i = 0; i < col; i++ )
{
    for ( int j = 0; j < row; j++ )
    {
        matrix1[ i, j ] = Convert.ToInt16( Console.ReadLine( ) );
    }
}

oziomajnr · Answer 2 · 2016-01-16T06:05:11.963

You initialized your matrix as a 0x0 matrix. Which is an empty matrix so you can't add or read anything from it.

Try this

   int row = 0; 
   int col = 0; 
   int[,] matrix1;
    row = Convert.ToInt16(Console.ReadLine()); 
  col = Convert.ToInt16(Console.ReadLine());

     matrix1=new int[row,col]; 
    Console.WriteLine("enter the numbers");
       for (int i = 0; i < col; i++) {
      for (int j = 0; j < row; j++) 
     {    
     matrix1[i, j] = Convert.ToInt16(Console.ReadLine());      } }

score 0 · Answer 3 · answered Jan 18 '21 at 16:02

0

        int row;
        int col;
        row = Convert.ToInt16(Console.ReadLine());
        col = Convert.ToInt16(Console.ReadLine());

        int[,] matrix1 = new int[row, col];
        Console.WriteLine("enter the numbers");
        for (int i = 0; i < col; i++)
        {
            for (int j = 0; j < row; j++)
            {
                matrix1[i, j] = Convert.ToInt16(Console.ReadLine());
            }
        }

answered Jan 18 '21 at 16:02

Nikola Simonovć

1
1

2

Please explain why this solves the question. [This](https://stackoverflow.com/help/how-to-answer) can help improve your answers. – shapiro yaacov Jan 18 '21 at 19:00
First you declare the number of columns and the number of rows in the matrix then you declare the matrix with the previously entered variables. In the end, just make classic for loops that are one inside the other. In the second loop, you enter the elements of the matrix. – Nikola Simonovć Jan 18 '21 at 20:20
1

Great. Could you add that to the answer itself? Makes it easier than looking through comments. Cheers! – shapiro yaacov Jan 18 '21 at 21:13

score 0 · Answer 4 · edited Jun 28 '21 at 11:03

0

int col = Convert.ToInt32(Console.ReadLine());
int row = Convert.ToInt32(Console.ReadLine());
int[,] matrix = new int[row, col];
for (int i = 0; i < matrix.GetLength(0); i++)
{
    for (int j = 0; j < matrix.GetLength(1); j++)
    {
        Console.Write($"enter row{i} and col{j} ");
        matrix[i, j] = Convert.ToInt16(Console.ReadLine());
    }

    Console.WriteLine();
}
for (int i = 0; i < matrix.GetLength(0); i++)
{
    for (int j = 0; j < matrix.GetLength(1); j++)
    {
        Console.Write(matrix[i, j]);
    }
    Console.WriteLine();
}

edited Jun 28 '21 at 11:03

Peter Csala

17,736
16
35
75

answered Jun 28 '21 at 06:27

zakaria ibrahim

1

1

Could you add a comment explaining what this code does? – Simas Joneliunas Jun 28 '21 at 06:51

filling matrix with user's input in C#

4 Answers4