RadioButton Clear Check Action

Question

I have a simple program that has 3 radio buttons in a group. When I click on any of the radio buttons I have a Toast appear to let the user know which button they have selected.

My problem I am facing is I have a onClick event for a button that clearCheck the radio group. When that happens, the Toast message appears again with the previous selected information from the radio button.

How do I prevent the toast from happening when I clearCheck the radio group?

public class MainActivity extends AppCompatActivity {

    RadioGroup radioGroup;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        // Initialize Radio Group and attach click handler
        radioGroup = (RadioGroup) findViewById(R.id.radioGroup);
        radioGroup.clearCheck();

        // Attach CheckedChangeListener to Radio Group
        radioGroup.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(RadioGroup group, int checkedId) {
                RadioButton rb = (RadioButton) group.findViewById(checkedId);
                if(null!=rb && checkedId > -1){
                    Toast.makeText(MainActivity.this, rb.getText(), Toast.LENGTH_SHORT).show();
                }
            }
        });
    }

    public void onClear(View v){
        // Clears the radio buttons when the clear button is pressed
        radioGroup.clearCheck();
    }

OP is not using any listener in class, rather its declared in the xml. — Rohit5k2, Jan 13 '16 at 14:29
try to write to log what value of checkId you'll have after `clearCheck` method. — dilix, Jan 13 '16 at 14:36
or wrapping : `if (checkedId != -1) {..... }` around everything inside onCheckChanged - do the check before doing anything else first? — Mark, Jan 13 '16 at 14:41

score -1 · Answer 1 · answered Jan 13 '16 at 14:26

-1

That is because clearing the check is changing the checked status of the radio group. You need to set a flag to let the listening know it should ignore that change.

Just a simple boolean declared in the class, flagged in onClear and checked in onCheckChanged (and reset the flag in onCheckChanged also).

answered Jan 13 '16 at 14:26

Knossos

15,802
10
54
91

onCheckedChanged: "Called when the checked radio button has changed. When the selection is cleared, checkedId is -1" this check `if(null!=rb && checkedId > -1){` should prevent toast showing. You extra flag will work but it's not a solution of a problem. – dilix Jan 13 '16 at 14:30

RadioButton Clear Check Action

1 Answers1