Make phpunit catch php7 TypeError

Question

I am trying to validate that a php7 function accept only integers.

This is the class:

<?php

declare(strict_types=1);

class Post
{
    private $id;

    public function setId(int $id)
    {
        $this->id = $id;
    }
}

And this is the test:

<?php

declare(strict_types=1);

class PostTest extends \PHPUnit_Framework_TestCase
{
    private function getPostEntity()
    {
        return new Post();
    }

    public function testSetId()
    {
        $valuesExpected = [123, '123a'];
        foreach ($valuesExpected as $input) {
            $this->getPostEntity()->setId($input);
        }
    }
}

The error I get is:

TypeError: Argument 1 passed to Post::setId() must be of the type integer, string given, called in /path/test/PostTest.php on line 35

Is it possible to validate such error? also, does it make any sense to run such a check?

score 24 · Accepted Answer · answered Dec 18 '15 at 08:12

24

Yes, you can test for TypeError the same way you would use for any other exception.

However, I would not test that PHP emits a type error in case of a type mismatch. This is the kind of test that becomes superfluous with PHP 7 code.

answered Dec 18 '15 at 08:12

Sebastian Bergmann

7,837
1
27
35

Could you give details about the superflous aspect of testing type mismatch? Why is it useless to check that I did not forget to add a type hint to `myMethod()`'s first argument, for instance? – marcv Oct 11 '17 at 16:26
1

This does not appear to be the case. From your own documentation: `By default, PHPUnit converts PHP errors, warnings, and notices that are triggered during the execution of a test to an exception.` It seems you would need `@expectedException PHPUnit\Framework\Error` to expect any PHP `Error`s (including `Error`s emitted via PHP 7 `assert()`), which is counter-intuitive to say the least. – chili Jan 23 '18 at 05:35
could you explain (maybe with a documentation referral) how to solve this problem? https://stackoverflow.com/questions/48486568/catch-an-error-as-exception – Michele Carino Jan 28 '18 at 13:17

score 9 · Answer 2 · answered May 31 '17 at 08:34

9

Try this:

$this->expectException(TypeError::class);

answered May 31 '17 at 08:34

Синкевич Алексей

107
1
1

Any useful reference? doc and etc? – michaelbn Jun 01 '17 at 08:45
1

That doesn't fix anything because as mentioned above TypeError is NOT a subclass of Exception. – Calamity Jane Aug 04 '17 at 14:06
@CalamityJane it certainly is at least in PHP 7.2 – Geoffrey Aug 12 '19 at 04:37
in 2017 I worked with Php7.0, glad if it is fixed in PHP 7.2! – Calamity Jane Aug 12 '19 at 13:11
1

`$this->expectException(TypeError::class);` did worked in PHP 7.0.33, 7.1.33, 7.2.30, 7.3.17 and 7.4.5. Here's the proven repo: https://github.com/KEINOS/Practice_PHPUnit-test-of-TypeHint Thanks. But unfortunately @pawel-ploczek's `$this->expectError(TypeError::class);` did not even the latest PHP (7.4.5). – KEINOS Apr 28 '20 at 07:06

score 5 · Answer 3 · edited May 23 '17 at 12:08

Sadly, TypeError is not a subclass of Exception (reference), whilst it extends Error. The only thing they are really sharing is the the Throwable interface. The ThrowMatcher can't actually catch a TypeError.

If you look at the code in src/PhpSpec/Matcher/ThrowMatcher.php, you can see that PHPSpec catches Exceptions that inherit 'Exception' and then checks the instance type of that exception.

Make phpunit catch php7 TypeError

6 Answers6