Generate a .csv file with php using foreach and while

Question

I tried to generate a .csv file, but I get this file empty. So my code is :

$fileName = 'Users_' . date('d-m-Y') . '.csv';
$fh = fopen($fileName, "w");
fputcsv($fh, array('EMAIL', 'NAME','SURNAME'), ";");
foreach ($aDataBases as $database) {
    $sSql = sprintf('SELECT email, name, surname FROM users');
    $rResult = Mysqli::query($sSql, $database);
    while ($aRecord = $rResult->fetch_array(MYSQLI_ASSOC)){
       fputcsv($fh, $aRecord['email'], ";");
       fputcsv($fh, $aRecord['name'], ";");
       fputcsv($fh, $aRecord['surname'], ";",'"');
    }
}
fclose($fh);

The file is generate but is empty, can you help me please ? I make a print_r() and there are data after query execution. What I'm doing wrong ?

score 3 · Accepted Answer · answered Dec 11 '15 at 15:09

You have to change this lines to

while ($aRecord = $rResult->fetch_array(MYSQLI_ASSOC)){
    fputcsv($fh, $aRecord['email'], ";");
    fputcsv($fh, $aRecord['name'], ";");
    fputcsv($fh, $aRecord['surname'], ";",'"');
}

to

while ($aRecord = $rResult->fetch_array(MYSQLI_ASSOC)){
    fputcsv($fh, [$aRecord['email'], $aRecord['name'], $aRecord['surname']]);
}

Check here http://php.net/manual/en/function.fputcsv.php#refsect1-function.fputcsv-parameters second parameter should be an array which you were missing

Yeah that's the problem! – Waqas Shahid Dec 11 '15 at 15:11 — Waqas Shahid, Dec 11 '15 at 15:11

score 1 · Answer 2 · answered Dec 11 '15 at 15:19

1

Second parameter to fputcsv should be an array, but in your code sample it's a string.

answered Dec 11 '15 at 15:19

Keilo

963
1
7
13

score 0 · Answer 3 · answered Dec 11 '15 at 15:27

The second parameter of fputcsv is an array.

You could do it like this:

$fields = [];

while ($aRecord = $rResult->fetch_array(MYSQLI_ASSOC)){
    $fields[] = $aRecord['email'];
    $fields[] = $aRecord['name'];
    $fields[] = $aRecord['surname'];

    fputcsv($fh, $fields);
}

Generate a .csv file with php using foreach and while

3 Answers3