java mkdirs did not work well (on Android platform)

Question

I have a problem with File.mkdirs().

[my test code]

public boolean makeFolder(Context context, String path){
    if(path == null || context == null)
       return false;

    File itemPath = new File(path);
    if(itemPath.isDirectory())
        return true; //happy time1 : because already exist.

    if(itemPath.mkdirs())
        return true; //happy time2 : because It's is goal.

    //now we have trouble.
    //itemPath is not directory and can not make that folder.
    //is itemPath one of files? ok find it out.

    // first of all, check a paranet folder path.
    File parent = itempath.getParentFile();
    if(parent == null) 
        return false;

    if(parent.isDirectory()){
        if(itemPath.isFile()){
            if(itemPath.delete() == false){
                return false;
            }
        }else{
            //This is the spot where I stocked.
            sendDownloadErrorLog("failed!!");
            return false;  //check point!!!
        }
    }else{
        return false;// parent is't folder!! How I can handle this!
    }
    //once more try make folder (because we try to delete same name file
    return itemPath.mkdirs();
}

I used this code when I make folder before downloading some files. and this code really really works well but not every time. Rarely I was reported "failed" exactly that spot! (check point!)

1. I checked dest folder existence.
2. I try to make dest folder.
3. I checked type of dest's parent (folder or not)
4. I try to delete file which has same name of dest folder. (if exist)
5. Finally, once more try to make a dest folder.

but sometimes step 4 was failed. itemPath(dest folder) is not exist. itemPath cant making up. itemPath's parent exist and she is folder. there is no file which has same name of itemPath. so why can't File.mkdirs make destFolder?

Is there any logical hole?

please let me know.

Answer 1

if(itemPath.isDirectory())
    return true; //happy time1 : because already exist.

OK

if(itemPath.mkdirs())
    return true; //happy time2 : because It's is goal.

OK

//now we have trouble.
//itemPath is not directory and can not make that folder.

That could mean several things:

1. It is a file.
2. You don't have write access to the parent directory.
3. The parent isn't a directory.

So:

if(parent.isDirectory()){
    if(itemPath.isFile()){
        if(itemPath.delete() == false){
            return false;

This is the case where item is a file, parent is a directory, and you don't have write access to the file or possibly the directory.

        }
    }else{
        //This is the spot where I stocked.

At this point, the parent is the directory, the item isn't a file, so it doesn't exist, and you failed to create it above, so you probably don't have write access to the parent directory.

        sendDownloadErrorLog("failed!!");
        return false;  //check point!!!
    }
}else{
    return false;// parent is't folder!! How I can handle this!

You can't and you shouldn't handle this. It is a user error, or a configuration problem. Not something to try and code around.

//once more try make folder (because we try to delete same name file
return itemPath.mkdirs();

I would say you are overcomplicating this. If you're supposed to be creating a directory and you can't because a file by that name already exists, that is an error, possibly on the part of the user. Tell him. You shouldn't react by deleting the file, it's none of your business why it's there. Similarly, if you don't have write access, that's the end of it. Nothing you can do. I would reduce the whole thing to this:

return itemPath.mkdirs();