prepare and execute in one method

Question

I need PDO's prepare() and execute() in one method... but it doesn' work. Environment: IIS 10 / SQL Server 2014

class dbh extends PDO {
    ...
    public function xquery($sql){
        if(($sth = $this->prepare($sql)) === false){
            $error_arr = $this->errorInfo();
            $this->error .= '<span title="error_code:'.$error_arr[0].'">(prepare) '.$error_arr[1].':'.$error_arr[2].'</span>';
        }

        if($sth->execute() === false){
            $error_arr = $sth->errorInfo();
            $this->error .= '<span title="error_code:'.$error_arr[0].'">(execute) '.$error_arr[1].':'.$error_arr[2].'</span>';
        }
    }
}

Calling method

$sql = "SELECT * FROM table";
$dbh->xquery($sql) OR die($dbh->error);

Any suggestions appritiated!

Doesn't look like you are actually executing anything! you need an array of data within the execute function... `$sth->execute()` — VIDesignz, Dec 05 '15 at 18:33

score 0 · Accepted Answer · answered Dec 05 '15 at 18:39

Found the bug... xquery() should return $sth

public function xquery($sql){
    if(($sth = $this->prepare($sql)) === false){
        $error_arr = $this->errorInfo();
        $this->error .= '<span title="error_code:'.$error_arr[0].'">(prepare) '.$error_arr[1].':'.$error_arr[2].'</span>';
    }

    if($sth->execute() === false){
        $error_arr = $sth->errorInfo();
        $this->error .= '<span title="error_code:'.$error_arr[0].'">(execute) '.$error_arr[1].':'.$error_arr[2].'</span>';
    }

    if(empty($this->error))
        return $sth;
}

prepare and execute in one method

1 Answers1