Code seems messy; asking if there is a better way

Question

New to building front-end web and this will be my first time raising a question here. I am using Flask to try it out but my code seems a bit of a mess. Is there a simpler way to implement this code?

            {% for data in dataList %}
              <tr>
                {% for d in data %}
                  {% if data.index(d) == 0 %}
                    {% if dataList.index(data) == 0 %}
                      <td> <input type="radio" name="option" value="{{d}}" checked> </td>
                    {%else%}
                      <td> <input type="radio" name="option" value="{{d}}"> </td>
                    {%endif%}
                  {%else%}
                    {% if d %}
                      <td> {{d}} </td>
                    {%endif%}
                  {%endif%}
                {% endfor %}
              </tr>
            {% endfor %}

You should do more data processing in the view or in a helper function and then send the simplified data to the template. — doru, Dec 04 '15 at 11:35

score 1 · Accepted Answer · answered Dec 04 '15 at 13:11

Inside of a for-loop block, you can access some special variables. loop.first equals True in first iteration.

{% for data in dataList %}
{% set outer_loop = loop %}
  <tr>
    {% for d in data %}
      {% if loop.first %}
        <td><input type="radio" name="option" value="{{d}}" {{"checked" if outer_loop.first}}></td>
      {% elif d %}
        <td>{{d}}</td>
      {% endif %}
    {% endfor %}
  </tr>
{% endfor %}

score 0 · Answer 2 · answered Dec 04 '15 at 12:38

If I was given this code to tidy up, I would probably end up with something like the following:

{% for data in dataList %}
    <tr>
        {% for d in data %}
            {% if data.index(d) == 0 %}
                <td>
                    <input type="radio" name="option" value="{{d}}" {% if dataList.index(data) == 0 %} checked {% endif %}>
                </td>
            {% else %}
                {% if d %}
                    <td>{{d}}</td>
                {% endif %}
            {% endif %} ## data.index(d) == 0
        {% endfor %} ## d in data
    </tr>
{% endfor %} ## data in dataList

Code seems messy; asking if there is a better way

2 Answers2