How to check if EditText has a value in Android / Java

Question

This should be simple, but I have tried if statements checking for null values and also ones checking the .length of it:

EditText marketValLow = (EditText) findViewById(R.id.marketValLow);
EditText marketValHigh = (EditText) findViewById(R.id.marketValHigh);
if (marketValLow.getText().length() != 0 && marketValHigh.getText().length() != 0) {
    Intent intent = new Intent();
    intent.setClass(v.getContext(), CurrentlyOwe.class);
    startActivity(intent);
} else {
    Toast.makeText(CurrentMarketValue.this, "You need to enter a high AND low.", Toast.LENGTH_SHORT);
}

But it doesn't detect nothing was entered. Any ideas?

score 38 · Accepted Answer · edited Sep 14 '15 at 03:55

38

Please compare string value not with == but equals() :

String yourString = ;
if (marketValHigh.getText().toString().equals(""))
{
    // This should work!
}

edited Sep 14 '15 at 03:55

kenju

5,866
1
41
41

answered Aug 04 '10 at 13:32

Sephy

50,022
30
123
131

As I said above: This works to stop progression to the next activity, but my toast does not show. Any ideas? Thanks! – Allen Gingrich Aug 04 '10 at 13:40
1

Whoops, my fault. Didn't add .show()! – Allen Gingrich Aug 04 '10 at 13:47
Damn it! so why "==" is incorrect here?! :O – ABS May 01 '14 at 12:55
This is Java code, in Java, if you want to compare String content you use equals, if you want to compare their pointer, you use == (which is pretty rare.) – Sephy May 10 '14 at 06:52
How about `marketValHigh.getText().length() != 0` ? – kenju Sep 14 '15 at 03:28

score 9 · Answer 2 · edited Jan 09 '13 at 18:23

9

This will check if the edit text is empty or not:

if (marketValLow.getText().toString().trim().equals(""))
{
}

edited Jan 09 '13 at 18:23

Rupert Russell

13
4

answered Aug 04 '10 at 13:33

Hare-Krishna

1,425
3
16
26

This works to stop progression to the next activity, but my toast does not show. Any ideas? Thanks! – Allen Gingrich Aug 04 '10 at 13:40
Toast.makeText(CurrentMarketValue.this, "You need to enter a high AND low.", Toast.LENGTH_SHORT).show(); This will work. – Hare-Krishna Aug 05 '10 at 04:29

Amit Lad · Answer 3 · 2016-01-14T10:05:27.847

2

Rather what you can check is like:

String text = mSearchText.getText().toString();

if (!TextUtils.isEmpty( mSearchText.getText().trim())) {
    // your code
}

edited Jan 14 '16 at 10:05

answered Aug 04 '10 at 14:50

Amit Lad

41
6

Sergio Abreu · Answer 4 · 2013-01-08T22:33:35.943

write a simple function inside a class:

    public static boolean isEditTextEmpty( EditText et){
      String s = et.getText().toString();
      return s.equals("");  // really empty.          
   }

    public static boolean isEditTextInvisible( EditText et){
      String s = et.getText().toString();
      return s.trim().equals("");  // might have only spaces...           
   }

OR... with positive Logic:

    public static boolean hasContentEditText( EditText et){
      String s = et.getText().toString();
      return s != null; // spaces will count.             
   }

score 0 · Answer 5 · answered Aug 04 '10 at 13:28

0

Maybe like this?

String value = editText.getText().toString();
if (value == "")
{
    // your code here
}

answered Aug 04 '10 at 13:28

Benny Skogberg

10,431
11
53
83

score 0 · Answer 6 · answered Aug 04 '10 at 18:27

If it stops progression to the next activity but doesn't show the toast there must be something wrong in your else statement. Have you read the Dev Guide article on Toast notifications? It is under User Interface -> Notifying the User -> Creating Toast Notifications.

score 0 · Answer 7 · edited Oct 29 '12 at 07:36

0

Validation is somewhat tedious. Maybe I can help you in a more generic manner. I have written a basic framework to validate fields in Android.

It is totally free, and you can do whatever you like with it.

edited Oct 29 '12 at 07:36

Ragunath Jawahar

19,513
22
110
155

answered Dec 23 '10 at 11:51

Jaavaaan

122
1
4

How to check if EditText has a value in Android / Java

7 Answers7