Not enough arguments for format string python

Question

On codacy it detects an issue where I dont have enough arguments for format string. Help please.

code:

self.notify.error("An item we don't have: track %s level %s was selected." % [track, level])

You might find str.format less error prone `"An item we don't have: track {} level {} was selected.".format(track, level)` — Padraic Cunningham, Nov 23 '15 at 17:30
post this is as an answer and ill mark it as resolved if it fixes it :) — Mgracer, Nov 23 '15 at 17:38
It will definitely work I just added an example using str.format as it is the preferred way in python to format strings and much more feature-full than the old style formatting. — Padraic Cunningham, Nov 23 '15 at 17:43
well this is correct solution so please post as an answer thank you :) — Mgracer, Nov 23 '15 at 17:46
@Mgracre, post the answer that worked and you can accept your own and get the rep ;) — Padraic Cunningham, Nov 23 '15 at 17:48

score 4 · Accepted Answer · answered Nov 23 '15 at 17:27

4

pass a tuple, not a list

self.notify.error("An item we don't have: track %s level %s was selected." % (track, level))

answered Nov 23 '15 at 17:27

Ayush

2

Or, if `.error()` is a logging function, omit the tuple altogether and just pass the arguments directly: `self.notify.error("An item we don't have: track %s level %s was selected.", track, level)` – John Gordon Nov 23 '15 at 17:29

score 2 · Answer 2 · answered Nov 23 '15 at 17:58

2

this is how i fixed it

"An item we don't have: track {} level {} was selected.".format(track, level)

answered Nov 23 '15 at 17:58

Mgracer

1

does anyone agree the 2 day wait makes no sense to accept your own answer? – Mgracer Nov 23 '15 at 18:00
While this is the preferred way of formatting strings nowadays, this doesn't answer the question as to why you were getting the error in the first place. The first answer does this well. Hence the two day waiting period: you might have a fix, but do you have an answer? – Adam Nov 23 '15 at 18:20

2 Answers2