setOnItemClickListener for listview

Question

I'am trying to click a button on my list view to update that row first of all I tried to click on the item in the list view to show toast.

I did setOnItemClickListener of the ListView

public class Medlistview extends Activity{
DB db = new DB(this);
ImageButton updateimagebutton = (ImageButton)findViewById(R.id.editbuttonimage);

@Override

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.medlistview);
    populatemedlistview();
}



public void populatemedlistview(){
    Cursor cursor = db.getMEDINF();

    String[] medinfo = new String[]{
            DB.col1,DB.col2,DB.col3,DB.col4,DB.rowID
    };
    int[] mappingmed = new int[]{
            R.id.MEDid,R.id.MedName,R.id.Medpurpose,R.id.medNotaplet,R.id.ROWID
    };

    SimpleCursorAdapter medcursoradapter = new SimpleCursorAdapter(this,R.layout.medlistviewxml,cursor,medinfo,mappingmed);
    ListView medlistview = (ListView)findViewById(R.id.listViewmed);
    medlistview.setAdapter(medcursoradapter);
    medlistview.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            Toast.makeText(Medlistview.this,"clicked",Toast.LENGTH_LONG).show();
        }
    });
}








}

I made sure that my list view is clickable and focusable but still not working

One more thing I already define image button on layout item not on ListVew layout every time I run the app, is crashing and showing that null reference message in the log-cat do I need to define the button also on the ListView layout.

 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.View android.view.Window.findViewById(int)' on a null object reference

My xml layout file.

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical" android:layout_width="match_parent"
android:layout_height="match_parent"
android:weightSum="1">

<ListView
  android:layout_width="match_parent"
    android:layout_height="282dp"
    android:id="@+id/listViewmed"
    android:layout_weight="0.40"
    android:background="#c7c0c0"
    android:clickable="true"
    android:focusable="true" />
  </LinearLayout>

Here is my list item xml layout file.

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent">

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceMedium"
    android:text="Medium Text"
    android:id="@+id/MEDid"
    android:layout_marginTop="40dp"
    android:layout_alignParentTop="true"
    android:layout_alignParentLeft="true"
    android:layout_alignParentStart="true"
    android:layout_marginBottom="10dp" />

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceMedium"
    android:text="Medium Text"
    android:id="@+id/MedName"
    android:layout_below="@+id/MEDid"
    android:layout_alignParentLeft="true"
    android:layout_marginBottom="10dp" />

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceMedium"
    android:text="Medium Text"
    android:id="@+id/Medpurpose"
    android:layout_below="@+id/MedName"
    android:layout_alignParentLeft="true"
    android:layout_marginBottom="10dp" />

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceMedium"
    android:text="Medium Text"
    android:id="@+id/medNotaplet"
    android:layout_below="@+id/Medpurpose"
    android:layout_alignParentLeft="true"
    android:layout_marginBottom="10dp" />

<ImageButton
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:id="@+id/editbuttonimage"
    android:layout_above="@+id/Medpurpose"
    android:layout_alignParentRight="true"
    android:layout_alignParentEnd="true"
    android:src="@drawable/editicon" />

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceSmall"
    android:text="Small Text"
    android:id="@+id/ROWID"
    android:layout_alignBottom="@+id/medNotaplet"
    android:layout_alignParentRight="true"
    android:layout_alignParentEnd="true" />
</RelativeLayout>

Thanks in Advance.

Log is very important for us to help you to find the problem. — ifeegoo, Nov 18 '15 at 10:38
about clicks on list, while you have buttons at list_item look here: http://stackoverflow.com/questions/5551042/onitemclicklistener-not-working-in-listview-android/14372750#14372750 Whats about error? Show your code, where you set onClickToButton and error logcat. — lewkka, Nov 18 '15 at 10:42
You can not click item in listView list with OnItemClickListener. See my answer below. — Vladimir Markeev, Nov 18 '15 at 10:46
@OWA you can only call this method `findViewById` only after `setContentView`. But you are calling before that, thats your `NullPointerException`. And if its already crashing how can you click on `ListView`? — Emil, Nov 18 '15 at 10:58
@Boss, with OnItemClickListener you can click only on all list item, to set action on view in list item you should use OnClickListener in adapter. please follow this link - http://stackoverflow.com/questions/6200604/set-onclicklistener-for-items-in-listview-with-2-views — Vladimir Markeev, Nov 18 '15 at 11:03
@vmarkeev we can click on ListView item with `ListView.OnItemClickListener`, we need to implement click listener inside the adapter only if we want to click any views inside a single item. And what I don't understand is that How can he click on listview if its already crashing? — Emil, Nov 18 '15 at 11:05
@Boss, according to "I'am trying to click a button on my list view", OWA want to click on view inside listView, so I recommended to use OnClickListener in adapter. — Vladimir Markeev, Nov 18 '15 at 11:12

score 0 · Answer 1 · answered Nov 18 '15 at 10:40

0

Set

android:focusable="false"
android:focusableInTouchMode="false"

for all UIs controls in your custom layout file.

answered Nov 18 '15 at 10:40

Piyush

18,895
5
32
63

Vladimir Markeev · Accepted Answer · 2015-11-18T14:25:49.600

0

Implement View.OnClickListener() to your ImageButton in getView() method in your adapter, not in Medlistview activity. And use callback or eventBus to work with click action in your activity.

@Override
public View getView(int position, View convertView, ViewGroup parent) {
    ViewHolder holder;

    if (convertView == null) {
        holder = new ViewHolder();
        convertView = inflater.inflate(R.layout.recycler_view_item, parent, false);
        holder.tvName = (TextView) convertView.findViewById(R.id.tvName);
        convertView.setTag(holder);
    } else {
        holder = (ViewHolder) convertView.getTag();
    }
    holder.tvName.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            // Button was clicked
        }
    });

    return convertView;
}

edited Nov 18 '15 at 14:25

answered Nov 18 '15 at 10:41

Vladimir Markeev

654
10
25

can you show me example of get view method please where i should use it – OWA Nov 18 '15 at 11:06
@OWA, follow this link - http://stackoverflow.com/questions/6200604/set-onclicklistener-for-items-in-listview-with-2-views – Vladimir Markeev Nov 18 '15 at 11:13
This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post. - [From Review](/review/low-quality-posts/10246215) – markpsmith Nov 18 '15 at 13:44
@markpsmith, I have updated my answer above with code snippet – Vladimir Markeev Nov 18 '15 at 14:28

score 0 · Answer 3 · edited May 23 '17 at 12:09

0

use android:descendantFocusability="blocksDescendants" inside listview, check out this answere: can't click on listview row with imagebutton

edited May 23 '17 at 12:09

Community

1
1

answered Nov 18 '15 at 11:04

Touf

106
1
6

score 0 · Answer 4 · edited Nov 18 '15 at 20:18

0

Set the parent layout of the item

android:descendantFocusability="blocksDescendants"

and set

android:clickable="false"
    android:focusable="false">

on all your widgets.

edited Nov 18 '15 at 20:18

Kendra

769
1
20
34

answered Nov 18 '15 at 11:06

Ibrahim Moustafa

1
2

setOnItemClickListener for listview

4 Answers4