3

How would you write ToUpper() if it didn't exist? Bonus points for i18n and L10n

Curiosity sparked by this: http://thedailywtf.com/Articles/The-Long-Way-toUpper.aspx

Mosty Mostacho
  • 42,742
  • 16
  • 96
  • 123
Colin Pickard
  • 45,724
  • 13
  • 98
  • 148

6 Answers6

8
  1. I download the Unicode tables
  2. I import the tables into a database
  3. I write a method upper().

Here is a sample implementation ;)

public static String upper(String s) {
    if (s == null) {
        return null;
    }

    final int N = s.length(); // Mind the optimization!
    PreparedStatement stmtName = null;
    PreparedStatement stmtSmall = null;
    ResultSet rsName = null;
    ResultSet rsSmall = null;
    StringBuilder buffer = new StringBuilder (N); // Much faster than StringBuffer!
    try {
        conn = DBFactory.getConnection();
        stmtName = conn.prepareStatement("select name from unicode.chart where codepoint = ?");
        // TODO Optimization: Maybe move this in the if() so we don't create this
        // unless there are uppercase characters in the string.
        stmtSmall = conn.prepareStatement("select codepoint from unicode.chart where name = ?");
        for (int i=0; i<N; i++) {
            int c = s.charAt(i);
            stmtName.setInt(1, c);
            rsName = stmtName.execute();
            if (rsName.next()) {
                String name = rsName.getString(1);
                if (name.contains(" SMALL ")) {
                    name = name.replaceAll(" SMALL ", " CAPITAL ");

                    stmtSmall.setString(1, name);
                    rsSmall = stmtSmall.execute();
                    if (rsSmall.next()) {
                        c = rsSmall.getInt(1);
                    }

                    rsSmall = DBUtil.close(rsSmall);
                }
            }
            rsName = DBUtil.close(rsName);
        }
    }
    finally {
        // Always clean up
        rsSmall = DBUtil.close(rsSmall);
        rsName = DBUtil.close(rsName);
        stmtSmall = DBUtil.close(stmtSmall);
        stmtName = DBUtil.close(stmtName);
    }

    // TODO Optimization: Maybe read the table once into RAM at the start
    // Would waste a lot of memory, though :/
    return buffer.toString();
}

;)

Note: The unicode charts which you can find on unicode.org contain the name of the character/code point. This string will contain " SMALL " for characters which are uppercase (mind the blanks or it might match "SMALLER" and the like). Now, you can search for a similar name with "SMALL" replaced with "CAPITAL". If you find it, you've found the captial version.

Aaron Digulla
  • 321,842
  • 108
  • 597
  • 820
7

I dont think SO can handle the size of the unicode tables in a single posting :)

Unfortunately, it is not so easy as just char.ToUpper() every character.

Example:

(string-upcase "Straße")    ⇒ "STRASSE"
(string-downcase "Straße")  ⇒ "straße"
(string-upcase "ΧΑΟΣ")      ⇒ "ΧΑΟΣ"
(string-downcase "ΧΑΟΣ")    ⇒ "χαος"
(string-downcase "ΧΑΟΣΣ")   ⇒ "χαοσς"
(string-downcase "ΧΑΟΣ Σ")  ⇒ "χαος σ"
(string-upcase "χαος")      ⇒ "ΧΑΟΣ"
(string-upcase "χαοσ")      ⇒ "ΧΑΟΣ"
Tomalak
  • 332,285
  • 67
  • 532
  • 628
leppie
  • 115,091
  • 17
  • 196
  • 297
  • (string-upcase "Straße") ⇒ "STRAẞE" – hangy Dec 02 '08 at 15:17
  • Hangy, sorry, that does not render. Also my conversions are local-independent (guess I should have mentioned that ;p). – leppie Dec 02 '08 at 16:04
  • And I simply pasted from the R6RS Scheme spec, it could be a typo, will check the tests. – leppie Dec 02 '08 at 16:05
  • Seems to be correct. These Scheme guys are really pedantic, I will take their word for it :) – leppie Dec 02 '08 at 16:07
  • 2
    The upper case ß was just added to the Unicode standard by updating some ISO standard back in April, so font support is really rare. :) Also, the Duden has not accepted it into the standard language, yet, so yours *is* correct. :) Just wanted to point another future possibility. – hangy Dec 03 '08 at 08:15
  • Thanks for the clarification, will reference your post :) – leppie Dec 03 '08 at 18:44
5

No static table is going to be sufficient because you need to know the language before you know the correct transforms.

e.g. In Turkish i needs to go to İ (U+0130) whereas in any other language is needs to go to I (U+0049) . And the i is the same character U+0069.

Douglas Leeder
  • 52,368
  • 9
  • 94
  • 137
  • 3
    Uff. I guess that's why a proper i18n library takes up >10MB. Crazy people. Why couldn't our ancestors just settle for a nice simple SINGLE writing system? :P – Vilx- Dec 02 '08 at 14:31
1

I won't win the bonus points, but here it is for 7-bit ASCII:

char toupper(char c)
{
    if ((c < 'a') || (c > 'z')) { return c; }
    else { return c & 0xdf; }
}
e.James
  • 116,942
  • 41
  • 177
  • 214
0

in python ..

touppe_map = { massive dictionary to handle all cases in all languages }
def to_upper( c ):
   return toupper_map.get( c, c )

or, if you want to do it the "wrong way"

def to_upper( c ):
  for k,v in toupper_map.items():
     if k == c: return v
  return c
hasen
  • 161,647
  • 65
  • 194
  • 231
0

Let me suggest even more bonus points for languages such as Hebrew, Arabic, Georgian and others that just do not have capital (upper case) letters. :-)

Boris Gorelik
  • 29,945
  • 39
  • 128
  • 170
  • for those languages it would be extremely simple ... anyway Arabic and Hebrew have their own set of string manipulation functionality they require. – hasen Dec 02 '08 at 14:21