ListView item not deleting/copying correctly even with view holder

Question

My listview isn't updating correctly when I try to remove or copy an item. The data is storing correctly in the database, but is not displayed correctly on the listview, which I think is due to issues with recycling views.

For example, I deleted an item with id 87, then I copied a different item and it showed up in the listview as having an id of 87 even though it should have been 88 (and was correctly stored in the db as 88).

I've tried looking at some other examples of code with view holders and custom adapters, but I can't seem to figure out the issue. Have I applied the ViewHolder concept correctly to my custom adapter?

public class WorkoutAdapter extends ArrayAdapter<ExerciseSetModel> {

    private Context context;
    private ArrayList<ExerciseSetModel> exerciseSetList;
    private JSONParser jParser = new JSONParser();
    private String isComplete;
    private String exerciseId;

    public WorkoutAdapter(Context context, ArrayList<ExerciseSetModel> objects) {

        super(context, R.layout.exercise_set_item, objects);

        this.context = context;
        this.exerciseSetList = objects;
        isComplete = "";
    }

    private class ViewHolder{
        TextView tvExerciseSetName;
        TextView tvExerciseSetDetails;
        CheckBox cbIsComplete;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {

        RelativeLayout view = (RelativeLayout) convertView;
        ViewHolder holder = null;

        if (view == null) {
            LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            view = (RelativeLayout) inflater.inflate(R.layout.exercise_set_item, parent, false);

            holder = new ViewHolder();
            holder.tvExerciseSetName = (TextView) view.findViewById(R.id.exerciseSetName);
            holder.tvExerciseSetDetails = (TextView) view.findViewById(R.id.exerciseSetDetails);
            holder.cbIsComplete = (CheckBox) view.findViewById(R.id.cbIsComplete);

            if (exerciseSetList.get(position).getIsComplete() == 1) {
                holder.cbIsComplete.setChecked(true);
                isComplete = "1";
            }
            else {
                holder.cbIsComplete.setChecked(false);
                isComplete = "0";
            }

            holder.cbIsComplete.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
                @Override
                public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                    if (isChecked) {
                        exerciseSetList.get(position).setIsComplete(1);
                        exerciseId = exerciseSetList.get(position).getExerciseId() + "";
                        isComplete = "1";
                    } else {
                        exerciseSetList.get(position).setIsComplete(0);
                        exerciseId = exerciseSetList.get(position).getExerciseId() + "";
                        isComplete = "0";
                    }
                    new UpdateExerciseComplete().execute();
                }
            });

            holder.tvExerciseSetName.setText(exerciseSetList.get(position).getExerciseName());
            holder.tvExerciseSetDetails.setText(exerciseSetList.get(position).getExerciseDetails() + " id: " + exerciseSetList.get(position).getExerciseId());

        }
        else{
            holder = (ViewHolder) view.getTag();
        }

        return view;
    }

    class UpdateExerciseComplete extends AsyncTask<String, String, String> {

        private String updateIsCompleteUrl;

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
        }

        protected String doInBackground(String... args) {

            updateIsCompleteUrl = "localhost/android_connect/updateIsComplete.php";

            LinkedHashMap<String, String> params = new LinkedHashMap<String, String>();
            params.put("is_complete", isComplete);
            params.put("exercise_id", exerciseId);
            jParser.makePostRequest(updateIsCompleteUrl, params);

            return null;
        }

        protected void onPostExecute(String file_url) {
        }
    }
}

Answer 1

For getting correct position in onclick() function. you have to tag position on your view holder.cbIsComplete.setTag(position) then get this tag inside onCLick() using int position=(Integer)buttonView.getTag()

Answer 2

You have implemented wrong ViewHolder pattern. replace modified getView

 @Override
public View getView(final int position, View convertView, ViewGroup parent) {

    RelativeLayout view = (RelativeLayout) convertView;
    ViewHolder holder = null;

    if (view == null) {
        LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        view = (RelativeLayout) inflater.inflate(R.layout.exercise_set_item, parent, false);

        holder = new ViewHolder();
        holder.tvExerciseSetName = (TextView) view.findViewById(R.id.exerciseSetName);
        holder.tvExerciseSetDetails = (TextView) view.findViewById(R.id.exerciseSetDetails);
        holder.cbIsComplete = (CheckBox) view.findViewById(R.id.cbIsComplete);
        view.setTag(holder); 
    }else{
        holder = (ViewHolder) view.getTag();
    }

    if (exerciseSetList.get(position).getIsComplete() == 1) {
        holder.cbIsComplete.setChecked(true);
        isComplete = "1";
    }
    else {
        holder.cbIsComplete.setChecked(false);
        isComplete = "0";
    }

    holder.cbIsComplete.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
        @Override
        public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
            if (isChecked) {
                exerciseSetList.get(position).setIsComplete(1);
                exerciseId = exerciseSetList.get(position).getExerciseId() + "";
                isComplete = "1";
            } else {
                exerciseSetList.get(position).setIsComplete(0);
                exerciseId = exerciseSetList.get(position).getExerciseId() + "";
                isComplete = "0";
            }
            new UpdateExerciseComplete().execute();
        }
    });

    holder.tvExerciseSetName.setText(exerciseSetList.get(position).getExerciseName());
    holder.tvExerciseSetDetails.setText(exerciseSetList.get(position).getExerciseDetails() + " id: " + exerciseSetList.get(position).getExerciseId());

    return view;
}