How to use ES2015 Template strings in an Ember helper

Asked Oct 15 '15 at 05:36

Active Oct 15 '15 at 05:36

Viewed 537 times

Ember > 2.0 + Ember suave are telling me:

"requireTemplateStringsForConcatenation: Using manual concatenation with strings is not allowed at helpers/svg-icon.js"

import Ember from 'ember';

export function svgIcon(iconName) {
  return Ember.String.htmlSafe("<svg class='icon-x'><use xlink:href='#icon-" +  iconName + "'></use></svg>");
}

export default Ember.Helper.helper(svgIcon);

I've just come from a meetup where Ember.string.fmt was discussed and sounded promising ~ but that has been deprecated and suggests you use ES2015 Template Strings.

Reading about those here: http://babeljs.io/docs/learn-es2015/

I am unclear about how 'manual' concatenation works - what the problem would be - and well, the whole thing.

return Ember.String.htmlSafe("<svg class='icon-x'><use xlink:href='#icon-${iconName}'></use></svg>"); ?

Implementation and reasoning happily accepted.

asked Oct 15 '15 at 05:36

sheriffderek

8,848
6
43
70

2

you ll want to replace your `"` with ` (backtick) – Patsy Issa Oct 15 '15 at 06:40
AH - they were so small - I didn't notice them in the docs. You should add your comment as an answer! Thanks. – sheriffderek Oct 15 '15 at 06:53
Close voting as typo is more appropriate in this case. – Patsy Issa Oct 15 '15 at 06:55
1

I don't see typo as an option in the vote to close. I also think that other people might also misread the docs. If someone throws Ember suave on a large projects - there will be many searches before they clear up all the warnings. – sheriffderek Oct 15 '15 at 07:11
The cv reason is under off topic > simple typographic error. – Patsy Issa Oct 15 '15 at 07:18

How to use ES2015 Template strings in an Ember helper

0 Answers0