Need a hand with debugging build.xml logic

Question

Below is the code snippet from my build.xml file, when the Beta target fails it's expected to rerun the same beta target, but the control isn't going to the retry logic upon beta failure, not sure what i am missing here

    <!-- US Beta Target -->
    <target name="test-integration-assert-beta">
       <test-environment country="US" stage="Beta" host.name="URL Goes Here" emailid="" password="" company="" invalidpassword="" materialset=""/>
           <echo message="integTest.failure = ${integTest.failure}" />
           <echo message="failedTests = ${failedTests}" />
           <condition property="failedTests">
               <and>
                   <istrue value="${integTest.failure}" />
                   <available file="${integ.test.dir}/testng-failed.xml" />
               </and>
           </condition>
           <antcall target="test-integration-assert-beta-rerun">
           </antcall>
    </target>   

    <!-- US Beta Target (Re-run) -->
        <target name="test-integration-assert-beta-rerun" description="Rerunning Failed Beta Tests" if="failedTests">
           <echo message="Running Failed Integration Tests..." />
           <echo message="rerunFailedTests.failure = ${rerunFailedTests.failure}" />
           <copy file="${output.dir}/brazil-integ-tests/testng-failed.xml"
              tofile="${output.dir}/testng-failed.xml" />
       <test-environment country="US" stage="Beta" host.name="URL Goes Here" emailid="" password="" company="" invalidpassword="" materialset=""/>
           <echo message="rerunFailedTests.failure = ${rerunFailedTests.failure}" />
           <fail message="Tests Failed on rerun">
               <condition>
                   <istrue value="${rerunFailedTests.failure}" />
               </condition>
           </fail>
        </target>

It seems there are problems with the tests if re-running them with the same inputs is going to result in a different outcome. — thekbb, Oct 09 '15 at 18:25

score 1 · Answer 1 · edited May 23 '17 at 11:52

<antcall> can be useful at times, but it has a lot of pitfalls that can make scripts difficult to reason about. In particular, <antcall> conflicts with the normal dependency flows of Ant.

Instead of <antcall>, consider using <target depends="..."> along with a <macrodef>:

The depends attribute of <target> enables conditional logic.
<macrodef> enables code reuse and reduces code duplication.

The following build.xml gives an example:

<project name="ant-macrodef-retry" default="run">
    <macrodef name="my-test-environment">
        <attribute name="try"/>
        <sequential>
            <echo>Call test-environment here.</echo>
            <!-- The following <condition> tasks are just for testing purposes. -->
            <!-- The real <test-environment> would set these properties. -->
            <condition property="integTest.failure" value="true">
                <and>
                    <equals arg1="@{try}" arg2="1"/>
                    <isset property="failTry1"/>
                </and>
            </condition>
            <condition property="rerunFailedTests.failure" value="true">
                <and>
                    <equals arg1="@{try}" arg2="2"/>
                    <isset property="failTry2"/>
                </and>
            </condition>
        </sequential>
    </macrodef>

    <target name="try1">
        <my-test-environment try="1"/>
        <echo message="integTest.failure = ${integTest.failure}" />
        <condition property="failedTests">
            <istrue value="${integTest.failure}" />
        </condition>
    </target>

    <target name="try2" if="failedTests">
        <echo message="Running Failed Integration Tests..." />
        <my-test-environment try="2"/>
        <echo message="rerunFailedTests.failure = ${rerunFailedTests.failure}" />
        <fail message="Tests Failed on rerun">
            <condition>
                <istrue value="${rerunFailedTests.failure}" />
            </condition>
        </fail>
    </target>

    <target name="run" depends="try1,try2"/>
</project>

Output

Below are various tests of the above Ant script. It shows how the script behaves in the various failure scenarios...

=================================
Test command line: ant

try1:
     [echo] Call test-environment here.
     [echo] integTest.failure = ${integTest.failure}

try2:

run:

BUILD SUCCESSFUL

=================================
Test command line: ant -DfailTry1=true

try1:
     [echo] Call test-environment here.
     [echo] integTest.failure = true

try2:
     [echo] Running Failed Integration Tests...
     [echo] Call test-environment here.
     [echo] rerunFailedTests.failure = ${rerunFailedTests.failure}

run:

BUILD SUCCESSFUL

=================================
Test command line: ant -DfailTry1=true -DfailTry2=true

try1:
     [echo] Call test-environment here.
     [echo] integTest.failure = true

try2:
     [echo] Running Failed Integration Tests...
     [echo] Call test-environment here.
     [echo] rerunFailedTests.failure = true

BUILD FAILED
C:\ant\build.xml:35: Tests Failed on rerun

sorry for the delay, was on a vacation. I got sometime to try this out today, — Tom, Oct 21 '15 at 12:40

Need a hand with debugging build.xml logic

1 Answers1

Output