Access violation writing location 0x00000000. When increase size of array to calloc

Question

I try to calloc 2d array and initial value of edge cell with 255, it work correctly but when I try to set dimension of array over than 12000*12000, VS2010 show Access violation writing location 0x00000000

my function of calloc 2d array

int **calloc_2d_int(int Rows, int Cols) {
      int *data = (int *)calloc(Rows*Cols,sizeof(int));
      int **array= (int **)calloc(Rows,sizeof(int*));
      for (int i=0; i<Rows; i++)
           array[i] = &(data[Cols*i]);
      return array;
}

main function

int main(int argc, char* argv[]){   

int i,j;

/*convert string to int*/
int row    = atoi(argv[1]);
int column      = atoi(argv[2]); 
int T           = atoi(argv[3]); 

int** s[2];

s[0] = calloc_2d_int(row,column);
s[1] = calloc_2d_int(row,column); 
for(i=0 ; i<row ; i++){
    s[0][i][0]        = 255;   //error at this line 
    s[1][i][0]        = 255;
    s[0][i][column-1] = 255;
    s[1][i][column-1] = 255;
}

for(i=0 ; i<column ; i++){
    s[0][0][i] = 255;
    s[1][0][i] = 255;
    s[0][row-1][i] = 255;
    s[1][row-1][i] = 255;

}
}

Thank you

Out of interest, why are you even using C-style memory allocation with `calloc` in a C++ program ? — Paul R, Oct 02 '15 at 08:41
Also I suggest you check the values of `row`, and particularly `column`, after the calls to `atoi()`, to make sure they are both > 0. — Paul R, Oct 02 '15 at 08:45
What values are you using for `row` and `column` ? Are they large ? Is it possible that `calloc` fails (NB: you have no error checking for this) ? — Paul R, Oct 02 '15 at 08:50
When dialog alert ,i just 0 ,it mean that it have error since start for. — ThSorn, Oct 02 '15 at 08:51
Another nice example showing why one shall always test the out come of calls to relevant library functions. — alk, Oct 02 '15 at 10:51

Aracthor · Accepted Answer · 2016-01-15T16:14:47.797

4

Access violation writing location 0x00000000

This means you are trying to write on a NULL pointer. So calloc returned NULL.

As you can read on the calloc manpage, it returns NULL on error, which can be a too big memory request.
Depending of your system, 13000 * 13000 (169 000 000) might be too big.

Always check malloc, calloc and realloc returns for an error.

edited Jan 15 '16 at 16:14

answered Oct 02 '15 at 08:54

Aracthor

5,757
6
31
59

Access violation writing location 0x00000000. When increase size of array to calloc

1 Answers1