Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index while fetch data using Sqldatareader

Question

Currently I am getting an error when attempting to fetch data using SqlDataReader and the parameter is in list i.e. on newcmd.Parameters.Add("@frmcat", res[i]);

Here is my code

        SqlDataAdapter adpt = new SqlDataAdapter("SELECT DISTINCT TOP 5 category, COUNT(category) AS totcom FROM coupon_deal WHERE (company LIKE '%" + query + "%') GROUP BY category ORDER BY totcom DESC", conn);
        DataTable dt = new DataTable();
        adpt.Fill(dt);

        int TotalRow = dt.Rows.Count;

        List<string> res = new List<string>();
        for (int i = 0; i < TotalRow; i++)
        {
            res.Add(dt.Rows[i]["category"].ToString());
        }

        List<string> cl = new List<string>();
        SqlCommand newcmd = new SqlCommand("SELECT company, count(company) AS totcomp from coupon_deal Where (category LIKE @frmcat) GROUP BY company ORDER BY totcomp DESC", conn);
        for (int i = 0; i <= res.Count; i++)
        {
            newcmd.Parameters.Clear();
            newcmd.Parameters.Add("@frmcat", res[i]);
            SqlDataReader sdr = newcmd.ExecuteReader();
            if (sdr.HasRows)
            {
                while (sdr.Read())
                {
                    cl.Add(sdr["company"].ToString());
                }
            }
            sdr.Close();
            sdr.Dispose();
        }

It's because you have <= res.count. try just – Maxqueue Sep 18 '15 at 20:56 — Maxqueue, Sep 18 '15 at 20:56

score 2 · Accepted Answer · answered Sep 18 '15 at 20:59

2

So i < res.Count should fix issue:

    for (int i = 0; i < res.Count; i++)
    {
        newcmd.Parameters.Clear();
        newcmd.Parameters.Add("@frmcat", res[i]);
        SqlDataReader sdr = newcmd.ExecuteReader();
        if (sdr.HasRows)
        {
            while (sdr.Read())
            {
                cl.Add(sdr["company"].ToString());
            }
        }
        sdr.Close();
        sdr.Dispose();
    }

answered Sep 18 '15 at 20:59

Maxqueue

2,194
2
23
55

I upvoted your comment but don't expect the same for this answer. – Eser Sep 18 '15 at 21:00

Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index while fetch data using Sqldatareader

1 Answers1