How to get trade_offer_state from Steam's API GetTradeOffer

Question

I have an object trade returned from Steam's API GetTradeOffer which contains the following:

tradeofferid=697052768, accountid_other=38044877, expiration_time=1443176120, trade_offer_state=7

if I console.log(trade) I get:

tradeofferid=697052768, accountid_other=38044877, expiration_time=1443176120, trade_offer_state=7

however if I do console.log(trade.trade_offer_state) I get undefined

Has anyone got any idea as to why?

EDIT:

Here is the full markup for this section:

function checkOffer(offer) {
    offers.getOffer({
        tradeOfferId: offer.trade_id.toString()
    }, function(err, trade) {
        if (err) {
            throw err;
        }
        logger.info(trade);
        if (trade.trade_offer_state == '7' || trade.trade_offer_state == '4' || trade.trade_offer_state == '5' || trade.trade_offer_state == '6' || trade.trade_offer_state == '9' || trade.trade_offer_state == '10') {
            connection.query('UPDATE `trade_queue` SET `offer_sent` = 0 WHERE `id` = ' + "'" + offer.id + "'", function(err, rows, fields) {
                if (err) {
                    throw err;
                }
                logger.info(rows[0]);
            });
        }

    });
}

@freefaller trade is returned from the GetTradeOffer (v1): https://developer.valvesoftware.com/wiki/Steam_Web_API/IEconService — Ricky Barnett, Sep 11 '15 at 10:54
If that was an object [it would work](http://jsfiddle.net/5mg3q163/). — Andy, Sep 11 '15 at 10:58
Assuming it's JSON, have you parsed it? `var obj = JSON.parse(json)`, for example? — Andy, Sep 11 '15 at 11:01
@Torben `{"response":{"offer":{"tradeofferid":"697052768","accountid_other":38044877, "expiration_time":1443176120,"trade_offer_state":7,` — Ricky Barnett, Sep 11 '15 at 11:08
Where exactly do you insert the `console.log` calls? In the first line of the function, before or after `logger.info` or anywhere else? — Torben, Sep 11 '15 at 11:10
@Torben `logger.info` acts as a `console.log()`: It outputs the following `Info: some output` — Ricky Barnett, Sep 11 '15 at 11:11

score 1 · Accepted Answer · answered Sep 11 '15 at 11:14

If your object is:

var trade = {
    "response": {
        "offer": {
            "tradeofferid": "697052768",
            "accountid_other": 38044877,
            "expiration_time": 1443176120,
            "trade_offer_state": 7
        }
    }
}

Then you get your value using:

var val = trade.response.offer.trade_offer_state; // 7

DEMO

karkael · Answer 2 · 2015-09-11T11:00:23.613

0

var trade = { 
    "tradeofferid": 697052768, 
    "accountid_other": 38044877, 
    "expiration_time": 1443176120, 
    "trade_offer_state": 7 
};

console.log( trade.trade_offer_state ); // same as
console.log( trade["trade_offer_state"] ); // both return 7

edited Sep 11 '15 at 11:00

answered Sep 11 '15 at 10:58

karkael

431
2
9

Still returns `undefined` – Ricky Barnett Sep 11 '15 at 10:58
Did you run it on your console browser ? – karkael Sep 11 '15 at 11:01
@karkael Read the comments of the question. He get's the data from an external source, your answer doesn't work for him – Reeno Sep 11 '15 at 11:03

score 0 · Answer 3 · answered Sep 11 '15 at 11:13

When var trade = "tradeofferid=697052768, accountid_other=38044877, expiration_time=1443176120, trade_offer_state=7";

You can add these lines:

function(err, trade) {
    eval.bind( this )( "var " + trade );
    trade = { 
        "tradeofferid": tradeofferid, 
        "accountid_other": accountid_other, 
        "expiration_time": expiration_time, 
        "trade_offer_state": trade_offer_state
    };
    if (err) {
        throw err;
    }
    logger.info(trade);
    if (trade.trade_offer_state == '7' || trade.trade_offer_state == '4' || trade.trade_offer_state == '5' || trade.trade_offer_state == '6' || trade.trade_offer_state == '9' || trade.trade_offer_state == '10') {
        connection.query('UPDATE `trade_queue` SET `offer_sent` = 0 WHERE `id` = ' + "'" + offer.id + "'", function(err, rows, fields) {
            if (err) {
                throw err;
            }
            logger.info(rows[0]);
        });
    }
}

OR

function(err, trade) {
    eval( trade );
    if (err) {
        throw err;
    }
    logger.info(trade);
    if (trade_offer_state == '7' || trade_offer_state == '4' || trade_offer_state == '5' || trade_offer_state == '6' || trade_offer_state == '9' || trade_offer_state == '10') {
        connection.query('UPDATE `trade_queue` SET `offer_sent` = 0 WHERE `id` = ' + "'" + offer.id + "'", function(err, rows, fields) {
            if (err) {
                throw err;
            }
            logger.info(rows[0]);
        });
    }
}

Forthemore, you can simply this line : `if( [7,4,5,6,9,10].indexOf( trade_offer_state ) != -1 ){ //...`. — karkael, Sep 11 '15 at 11:17

How to get trade_offer_state from Steam's API GetTradeOffer

3 Answers3