Error in either if statement or in query

Question

All I want to know is weather my problem resides in my "if" statement or in my query... If you want to be generous and help me further than that it would be appreciated but as a beginner I feel its good for me to trouble shoot for myself.

My problem is that no matter what value I put into the editText box the result is returning true(taking me to the next screen of my app). Unless I leave it blank which it is then doing what it is supposed to which is showing a text saying "You did not enter a password" Can someone please tell me where my problem lies?

public void buttonWork() {
        button_credCheck.setOnClickListener(new View.OnClickListener() {

        @Override
       public void onClick(View v) {
        Integer rpq = regPwdQuery();
            String isEnteredStr = editText_pwdInput.getText().toString();
            if (TextUtils.isEmpty(isEnteredStr)) {
                Toast.makeText(LogInActivity.this, "You did not enter a password!", Toast.LENGTH_LONG).show();
            }
            else if
                (rpq.equals(1)) {
                Intent myIntent = new Intent(LogInActivity.this, FindInfoActivity.class);
                startActivity(myIntent);
            }
            else {
                Toast.makeText(LogInActivity.this, "Incorrect Password", Toast.LENGTH_LONG).show();
            }
        }
    });
}

public Integer regPwdQuery() {
    int count = 0;
    String regPwdData = editText_pwdInput.getText.toString();
    String regQuery = "SELECT COUNT(*) AS COUNT FROM UsrPass_table WHERE Pwrd ='" + regPwdData + "'";
    SQLiteDatabase uDB = usrDB.getReadableDatabase();
    Cursor cursor = uDB.rawQuery(regQuery, null);
    while (cursor.moveToNext()){
       count = cursor.getCount();
    }
    cursor.close();
    return count;
}

EDIT: I have tried changing my else if to: rpq.equals(2) since I was told that getCount will always return 1. This caused the all passwords (even correct ones, verified to exist in DB) to be blocked saying incorrect password.. so if I leave my if statement to check for a 1 then it doesn't block incorrect passwords and if I set my if statement to check for 2 then it blocks everything.. my assumption is that the error is in my query somewhere... maybe I need a way to add 1 to "cnt" if the query returns true... I tried adding a cnt++ in a few different places of my regPwdQuery but no luck.. can anyone help me?

Answer 1

you are trying to check the password with database while setting on click listener not inside the onclick function!! Move

String rpq = regPwdQuery().toString();   

inside onclick function.

and as pointed out by @Blackbelt, inside regPwdQuery() get text from edittext using

editText_pwdInput.getText().toString().

Side Note:

get readableDatabase whenever you are not writing anything to database.

Isn't better to directly compare integers. I dont see why it needs to be converted to strings to be compared. you can

replace

rpq.equals("1")

with

if (regPwdQuery() == 1) 

Db is not closed. check if it is intended.

Get rid of AS COUNT in your query since you are not doing any group by query.

Wrong assumption taht getCount returns 1 by default. It gives 0 in case no records are matching. Since you are consistently getting 1 as result, no matter what, you always have one record matching.

this one record is the one which consists of count as its value. so you need to query it to get count. (In case your count is 0 also you have one cursor record to give the result as 0)

finally please try following code. Instead of

count = cursor.getCount();

Can you try with this ?

count= cursor.getInt(0);

Answer 2

is it because in onClick you are checking the value of rpq rather than isEnteredStr? (You are checking isEnteredStr to see if it contains anything, but not when you are checking for the value)

Answer 3

Call regPwdQuery method in onClikc method after checking if entered string is not empty, implement if else logic there to handle successful or failure in authentication there.

Answer 4

Strange that you're converting from an Integer to a String and then checking if it is equal to "1". It would be easier if you just kept is as an integer. But as it is, try this:

else if (riq.equalsIgnoreCase("1")) {
    //your code here
}