NSDate throwing BAD_EXCESS for what?

Question

I have below.

@interface MyViewController () {
    NSDate *myCurrentDate;
}

@implementation MyViewController

-(void)viewDidLoad {
    [super viewDidLoad];
    myCurrentDate = [NSDate date];
}  


- (IBAction) prevAction:(id)sender {
    NSLog(@"myCurrentDate===%@", myCurrentDate); // here it says 
    myCurrentDate = [myCurrentDate dateByAddingTimeInterval:60*60*24*-1];
    [self formatDateAndPostOnButton];
}

When I try to print current date as below, it crash saying BAD_EXCESS

NSLog(@"myCurrentDate===%@", myCurrentDate);

Below is the screenshot for the same.

I'm not using ARC in my project.

Any idea what is going wrong?

Are these the only references to mCurrentDate? Or where else are you using it. In these lines of code I do not see any flaw. — Hermann Klecker, Aug 25 '15 at 08:07
Did you doublecheck by step-for-step-debugging that the exception is really trown on that very line. — Hermann Klecker, Aug 25 '15 at 08:07
@HermannKlecker : I have previous and next button... I update the variable `myCurrentDate` and then I update the label for display... — Fahim Parkar, Aug 25 '15 at 08:08
what does it happen actually between `–viewdidLoad` and `–prevAction:` methods? — holex, Aug 25 '15 at 08:09
When you don't ARC then you should retain mCurrentDate. And don't forget to release it on -dealloc. `mCurrentDate = [[NSDate date] retain];` — Hermann Klecker, Aug 25 '15 at 08:11
Then better use ARC since you don't understand basics of memory management. That will help you building your application instead of fighting exceptions. — Grzegorz Krukowski, Aug 25 '15 at 08:17
The variable is being released by the auto-release pool but the reference remains. — trojanfoe, Aug 25 '15 at 08:19

Grzegorz Krukowski · Accepted Answer · 2015-08-25T08:18:44.760

Since you are not using ARC, easiest way to retain objects is to use generated setters/getters.

Instead of:

@interface MyViewController () {
    NSDate *myCurrentDate;
}

make

@interface MyViewController ()
@property(nonatomic, retain) NSDate* myCurrentDate;
@end

So it will keep NSDate retained. Right now your NSDate gets deallocated when the auto-release pool is drained.

You will need to use the getters/setters provided, however:

self.myCurrentDate = [self.myCurrentDate dateByAddingTimeInterval:60*60*24*-1];

Anyways I would recommend start using ARC to make your life simpler and avoid strange memory crashes.

You can't add property to interface variable block. – John Tracid Aug 25 '15 at 08:14 — John Tracid, Aug 25 '15 at 08:14

NSDate throwing BAD_EXCESS for what?

1 Answers1