Better way to rewrite an if else sequence

Question

I want to ask what is the better to write this sequence of if else statements :

$dir = base_url()."assets/produits/";
  $img_src = $dir."none.png";

  if (!empty($row->nShape)) {
      $nom = $row->nShape;

  if (file_exists($dir.$nom.".JPEG")) {
      $img_src = $dir.$nom.".JPEG";
  }
  else
  if (file_exists($dir.$nom.".jpg")) {
      $img_src = $dir.$nom.".jpg";
  }
  else
  if (file_exists($dir.$nom.".jpeg")) {
      $img_src = $dir.$nom.".jpeg";
  }
  }

The Full MVC Pattern

After implementing : https://stackoverflow.com/a/32034937/5203821 answer

The View File

<div class="container">
    <?=$message?>
    <?php
    foreach ($rows as $row) {
    $dir = base_url()."assets/produits/";
    $img_src = $dir."none.png";

    if (!empty($row->nShape)) {
            $nom = $row->nShape;

    $type = array(".JPEG", ".jpg", ".jpeg");

    foreach ($type as $ext) {
        if (file_exists($dir.$nom.$ext)) {
            $img_src = $dir.$nom.$ext;
            break;
        }
    }
}

    ?>

    <div class="list-group">
        <a class="list-group-item col-md-4" target="_blanc" href="<?=site_url()?>/produits/detail/<?=$row->nProduct?>" title="<?=$row->sSort?>"><b><img src="<?=$img_src?>" alt="<?=$row->nShape?>" class="img-rounded product"><?=$row->sSearch?></b></a>
    </div>
    <?php
    }
     ?>
    <div class="spacer"></div>
</div>

Model File

<?php

defined('BASEPATH') OR exit('No direct script access allowed');
    class Product_model extends CI_Model{

      function getProduct($product_id){
        $this->db->from('tequivalent')
                  ->where('nReference',$product_id)
                  ->join('tProduct','tProduct.nProduct=tequivalent.nProduct1');

                $query = $this->db->get();
                $ret['rows'] = $query->result();
                $ret['number'] = $query->num_rows();
                $ret['id'] = $product_id;

                return $ret;
      }
    }

Controller File

<?php
if ( ! defined('BASEPATH')) exit('No direct script access allowed');
class Produits extends CI_Controller {


    function index($product_id='')
    {

        if($product_id==NULL){
            redirect();
        }
        $this->load->model('Product_model');
        $query = $this->Product_model->getProduct($product_id = $this->uri->segment(3, 0));

        if($query['number']>0){
            $results['message']="<h2>Clique sur une Référence pour Plus de Detail</h2>";
            $results['number'] = $query['number'];
            $results['rows'] = $query['rows'];
        }else{
            $results['message'] = "<p>Oops! Y'a Aucun Résultat pour cette recherche</p>";
            $results['message'] .= "<a class='btn btn-lg btn-danger' href=".site_url().">Acceuil</a>";
            $results['number'] = $query['number'];
            $results['rows'] = $query['rows'];
            $results['id'] = $query['id'];
        }

        $this->load->view('constants/header');
        $this->load->view('produits',$results);
        $this->load->view('constants/footer');

}
}

The above code if the the full MVC Pattern since I'm using Codeigniter And thanks to all of you for your contributions

If you cannot standardize the way the files are saved, I would probably `glob()` the directory and do a case non-sensitive match against the resulting array. — jeroen, Aug 16 '15 at 11:55

score 1 · Answer 1 · edited May 23 '17 at 12:22

1

you can use this function taken from here, that ignores case:

function fileExists($fileName, $caseSensitive = true) {

    if(file_exists($fileName)) {
        return $fileName;
    }
    if($caseSensitive) return false;

    // Handle case insensitive requests            
    $directoryName = dirname($fileName);
    $fileArray = glob($directoryName . '/*', GLOB_NOSORT);
    $fileNameLowerCase = strtolower($fileName);
    foreach($fileArray as $file) {
        if(strtolower($file) == $fileNameLowerCase) {
            return $file;
        }
    }
    return false;
}

now you can iterate:

$allowedExtensions = ["jpeg","jpg"];

foreach($allowedExtensions as $ext){
     if(fileExists("youfFileName.$ext"),false){
         //do your code..
     }
}

edited May 23 '17 at 12:22

Community

1
1

answered Aug 16 '15 at 12:12

Daniel Krom

9,751
3
43
44

But where I CAN DETERMINE A SPECIFIED DIRECTORY? – Rahmani Seif El Moulouk Aug 16 '15 at 13:48
just send the full path "full/path/to/file/file.jpg"; the fileExists knows how to search inside the folder of the file using dirname($fileName); – Daniel Krom Aug 16 '15 at 13:52
But I can't use a function inside a foreach loop, checkout the above in the question – Rahmani Seif El Moulouk Aug 16 '15 at 14:09
why you can't? I don't see the reason – Daniel Krom Aug 16 '15 at 14:44
`Cannot redeclare fileExists() (previously declared in C:\xampp\htdocs\dedax_new\application\views\produits.php:9)` – Rahmani Seif El Moulouk Aug 16 '15 at 14:53

score 1 · Accepted Answer · answered Aug 16 '15 at 12:12

1

You could probably consolidate the three if statements using a foreach loop:

dir = base_url()."assets/produits/";
    $img_src = $dir."none.png";

    if (!empty($row->nShape)) {
            $nom = $row->nShape;

    $type = array(".JPEG", ".jpg", ".jpeg");

    foreach ($type as $ext) {
        if (file_exists($dir.$nom.$ext)) {
            $img_src = $dir.$nom.$ext;
            break;
        }
    }
}

By adding the extensions to an array can significantly reduce the redundant if statements.