Rails3: warning: toplevel constant ApplicationController referenced by

Question

Everytime i get a warning:

app/controllers/agency/agencies_controller.rb:1: warning: toplevel constant ApplicationController referenced by Agency::ApplicationController

My agencies_controller.rb:

class Agency::AgenciesController < Agency::ApplicationController

  def index
    ...
  end 

  ...
end

And Agency::ApplicationController:

class Agency::ApplicationController < ApplicationController
  layout 'agency'

  helper_method :current_agency
  private

  def current_agency
    @current_agency ||= current_user.agency 
  end

end

What the rails wants from me? What is the trouble?

Same situation with another controller

class Agency::ClientsController < Agency::ApplicationController
  ...
end

And no warnings, no errors...

score 12 · Answer 1 · edited May 23 '17 at 11:53

I realize this question is almost two years old but I recently stumbled upon this through another stackoverflow post and wanted to share some insight.

Basically, if your namespace Agency happens to be a class instead of a module, you'll get that warning. In the stackoverflow post I pasted above, they had a model (class) of Admin and their namespace was also Admin.

This provides a better explanation of what is happening.

So check to see if your code isn't defining an Agency class somewhere. Good luck.

score 7 · Answer 2 · answered Sep 28 '11 at 16:07

7

I had similar issues running Spork and Watchr in my Admin namespaced controllers. So i've fixed this by adding following code into each_run block in spec_helper.rb:

Dir[File.expand_path("app/controllers/admin/*.rb")].each do |file|
    require file
end

All credits goes to guy from this thread

answered Sep 28 '11 at 16:07

Vadim Chumel

165
1
5

1

Thanks this worked great, I modified it a bit though for brevity: Dir[Rails.root.join("app/controllers/admin/*.rb")].each {|f| require f} – Matt Smith Feb 02 '12 at 09:36
after hours of banging my head.. this resolved my issue.. good that i noticed that warning and good that i found this answer.. thanks a lot. – whizcreed Jul 18 '12 at 13:15

score 5 · Answer 3 · answered Jul 04 '10 at 18:18

5

ApplicationController is the name of the superclass controller that Rails generates for you when you create a new project that all your other controller classes inherit from. There's probably a conflict somewhere because you've used the same name, even though you put it within a namespace.

Try giving your Agency::ApplicationController a different name.

answered Jul 04 '10 at 18:18

John Topley

113,588
46
195
237

But why there are no troubles with Agency::ClientsController?? – petRUShka Jul 07 '10 at 11:35
1

Because `ClientsController` doesn't have a special meaning to Rails. – John Topley Jul 07 '10 at 12:32
I have a functioning Admin::ApplicationController which doesn't give problems. So renaming should not be required. There is probably ambiguity elsewhere in the call stack, which Ruby is complaining about. – Joost Baaij Jan 04 '12 at 15:54

score 2 · Answer 4 · answered Aug 09 '12 at 10:42

2

In my case it was the problem with Devise. I had a devise model Admin and a namespaced routes Admin. Changing the namespaced route to Admins solved the problem.

answered Aug 09 '12 at 10:42

tundrax

21
1

score 2 · Answer 5 · answered Sep 01 '11 at 18:36

I had similar issues, after setting up Spork and Watchr. In the process, I turned off class cacheing (config_cache_classes => false in config/environments/test.rb) so that changes would be reloaded as necessary in the spork environment. Turning class cacheing back on made the warnings go away.

score 0 · Answer 6 · answered Mar 11 '15 at 12:18

0

Solution for me was add this line:

# spec/rails_helper.rb
Dir[File.expand_path("app/controllers/admin/*.rb")].each { |file| require file }

answered Mar 11 '15 at 12:18

Štefan Bartoš

561
6
8

Rails3: warning: toplevel constant ApplicationController referenced by

6 Answers6