Laravel 5 Querying with relations causes "Call to a member function addEagerConstraints() on null" error

Question

I have been trying to create a simple user management system but keep on hitting road blocks when it comes to querying relations. For example I have users and roles and whenever I try to make a query for all users and their roles I get an error. The one in the title is only the latest one I've encountered.

My User and Role Models look like this:

class Role extends Model
{
    public function users()
    {
        $this->belongsToMany('\App\User', 'fk_role_user', 'role_id', 'user_id');
    }
}

class User extends Model
{
    public function roles()
    {
        $this->belongsToMany('\App\Role', 'fk_user_role', 'user_id', 'role_id');
    }
}

My migration table for many-to-many relationship between the two looks like this:

public function up()
    {
        Schema::create('role_user', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('user_id')->unsigned()->nullable(); //fk => users
            $table->integer('role_id')->unsigned()->nullable(); //fk => roles

            $table->foreign('fk_user_role')->references('id')->on('users')->onDelete('cascade');
            $table->foreign('fk_role_user')->references('id')->on('roles')->onDelete('cascade');
        });
    }

And then I try to get all records with their relation in a controller:

public function index()
{
    $users = User::with('roles')->get();

    return $users;
}

So I need another pair of eyes to tell me what is it I am missing here?

jedrzej.kurylo · Accepted Answer · 2015-12-17T09:30:11.243

298

You are missing return statements in the methods that define relations. They need to return relation definition.

Replace

public function roles()
{
    $this->belongsToMany('\App\Role', 'fk_user_role', 'user_id', 'role_id');
}

With

public function roles()
{
    return $this->belongsToMany('\App\Role', 'role_user', 'user_id', 'role_id');
}

edited Dec 17 '15 at 09:30

answered Jul 21 '15 at 17:59

jedrzej.kurylo

39,591
9
98
107

1

Also for anyone else reading this with the same problem I needed to fix the second parameter from "fk_user_role" to "role_user". – Tomkarho Jul 21 '15 at 18:38
It's frustrating, it's just not returning – Mr.Thanks Apr 21 '18 at 09:37
may I ask you to have a look at a Laravel join related question at https://stackoverflow.com/questions/52149031/laravel-join-query-with-conditions ? – Istiaque Ahmed Sep 04 '18 at 05:51

score 13 · Answer 2 · edited Dec 20 '22 at 10:06

13

You forgot the return in your functions

Do:

return $this->belongsToMany('\App\User', 'fk_role_user', 'role_id', 'user_id');

return $this->belongsToMany('\App\Role', 'fk_user_role', 'user_id', 'role_id');

edited Dec 20 '22 at 10:06

TarangP

2,711
5
20
41

answered Sep 01 '20 at 19:38

Leonel Kahameni

793
8
10

score 8 · Answer 3 · answered Jun 07 '21 at 14:07

8

You need to use Return for your function's result. If you do not do that, Laravel does not know What should do with that function without any action. Just use like this

return $this->hasOne(xxx, xx, xx);

Enjoy your coding !

answered Jun 07 '21 at 14:07

Enver

542
5
7

score 1 · Answer 4 · answered May 18 '21 at 13:03

1

Make sure you have written return in your model function relation.

return $this->hasMany('App\StaffShift','user_id','user_id');

answered May 18 '21 at 13:03

Kaleemullah

446
3
8

Laravel 5 Querying with relations causes "Call to a member function addEagerConstraints() on null" error

4 Answers4