CppCheck does not detect memory leak

Question

Have following code, but CppCheck(1.68) detects only "style" error.

AbstractTelegram *TelegramFactory::CreateGetWigWagParameterTelegram(BYTE     Address_i, BYTE SubAddress_i, BYTE Tag_i)
{
   SignDataWigWag *pWigWag = new SignDataWigWag();

   return new SendTelegram(SubAddress_i, Tag_i, Telegram::GET_WIG_WAG,NULL,0);
}

Output:

Variable 'pWigWag' is assigned a value that is never used.
Variable 'pWigWag' is assigned a value that is never used.

Any options to tune?

score 3 · Answer 1 · answered Jul 14 '15 at 11:14

I am a Cppcheck developer.

Actually.. we can't see that there is definitely a memory leak in that code.

There are classes that has automatic memory management.

Imagine for example that the SignDataWigWag constructor has such code:

SignDataWigWag::SignDataWigWag() {
    instances.push_back(this);
}

then it can be deleted later by using for instance:

void deleteAllInstances() {
    while (!instances.empty()) {
        delete instances.back();
        instances.pop_back();
    }
}

This is not unusual. Some popular class libraries has lots of classes with some kind of memory management so manual delete is not needed..

there used to be an option to tune this. but as far as I know you can't tune this currently. maybe there will be an option to tune this better someday. — Daniel Marjamäki, Jul 14 '15 at 15:23

score 0 · Answer 2 · answered Jul 14 '15 at 08:05

0

cppcheck is essentially only a style-checker (and like other tools which incorporate the developer's notion of "good style", its usefulness depends on various factors).

There are suitable tools for detecting memory leaks (such as valgrind); cppcheck is not one of those. Of course, you will find differing opinions on which are the best tools, and even on what a tool is suitable for, e.g., a blog entry *Valgrind is NOT a leak checker *

answered Jul 14 '15 at 08:05

Thomas Dickey

51,086
7
70
105

What? Do you understand the difference between static code analysis and run-time checks? – blackhearted Jul 14 '15 at 08:13
Do you understand the difference between constructive and constructive criticism? – Thomas Dickey Jul 14 '15 at 08:58
I do, but, seems, you have problems reading the questions before replying. – blackhearted Jul 14 '15 at 09:01
I'm familiar with the tools available, and you have provided no evidence of that in any respect. – Thomas Dickey Jul 14 '15 at 09:06
So, you still comparing valgrind and cppcheck, right? – blackhearted Jul 14 '15 at 09:09

CppCheck does not detect memory leak

2 Answers2