Error: "angular was used before it was defined" but online editors able to output the result

Question

I couldn't get an output from this code when I ran it my local machine but the weird part is online editors able to give me an output: http://codepen.io/anon/pen/waXGom

*Im using Adobe Brackets editor

Here is my HTML code:

    <!DOCTYPE html >
  <html>
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.9/angular.min.js"></script>
    <script src= "app.js"></script>    
    <body ng-app="MyApp">

<div ng-controller="Controller2">
    <button ng-click="add()">Add Object</button>
    <button ng-click="reset()">Reset</button>
    <div remove="remove($index)" ng-repeat="name in names">
        {{name}}
    </div>
</div>

</body>
</html>

Here is my JS code:

var myApp = angular.module('myApp', []);

    myApp.controller('Controller2', function ($scope) {
        $scope.names = [];
    var data = ['Dean', 'Andy', 'Dan', 'Wizek', 'Pete', 'Pawel', 'Chris', 'Misko'];
    $scope.add = function() {
        if (data.length)
            $scope.names.push(data.pop());
    };

        $scope.reset = function(index) {
        data.push($scope.names.splice(index, 1)[0]);
    };
    });

Please help me to figure it out...

@VineetI'm getting this error in console: Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.4.2/$injector/modulerr?p0=MyApp&p1=Error%3A%2…%20at%20Ac.d%20(http%3A%2F%2F127.0.0.1%3A55063%2Fangular.min.js%3A19%3A339) Failed to load resource: the server responded with a status of 404 (Not Found) — RAOUL, Jul 13 '15 at 18:25
I'm not suggesting that head tags are a solution to this problem. They're required in your document. — isherwood, Jul 13 '15 at 19:36

ruffin · Answer 1 · 2016-08-11T14:18:14.453

Do you mean you see the angular used before it was defined error from JSLint? That'd be because you're using angular, a global, in your JavaScript code without letting JSLint know it's in scope first.

JSLint operates on a page-by-page level, and can't tell what's in the global context from outside includes. You've loaded Angular into the global context in another include, but JSLint can't tell that when it looks at this single JavaScript file by itself.

To be clear, then, just this line should already cause JSLint to report the error:

var myApp = angular.module('myApp', []);

You have to add a global directive to let JSLint know what's in the global context.

/*global angular */
var myApp = angular.module('myApp', []);

Now you're golden.

Just for fun, here's a fully JSLinted version of your JavaScript file snippet. Didn't take much. Note that I had to add squiggly brackets around your if block and the jslint directive white:true for what it considers non-standard whitespace. More on all that here.

/*jslint white:true */
/*global angular */
var myApp = angular.module('myApp', []);
myApp.controller('Controller2', function ($scope) {
    "use strict";

    $scope.names = [];
    var data = ['Dean', 'Andy', 'Dan', 'Wizek', 'Pete', 'Pawel', 'Chris', 'Misko'];
    $scope.add = function() {
        if (data.length)
        {
            $scope.names.push(data.pop());
        }
    };

    $scope.reset = function(index) {
        data.push($scope.names.splice(index, 1)[0]);
    };
});

score 1 · Answer 2 · edited Mar 28 '16 at 05:58

1

Just above your app declaration, add the following comment...

/* global angular */

It should look like this...

/ * global angular */
var myApp = angular.module('myApp', []);

The comment can contain a comma separated list of variables which lets JSLint know they (can/may have been) be declared in other files.

edited Mar 28 '16 at 05:58

Kishor

2,659
4
16
34

answered Mar 28 '16 at 05:13

Ion

11
1

In my case I had to remove the space, `/*global angular */`, or JSLint would argue about. – srodriguex Nov 28 '16 at 22:47

score 0 · Answer 3 · edited Jul 13 '15 at 19:37

There is a typo I am getting. In your HTML you're using

<body ng-app="MyApp">

and in controller

angular.module('myApp', []);

You should use

<body ng-app="myApp">

You're getting console error because your page had included AngularJS. Its not consider a good practice to load scripts in head or start of the page. You should load all scripts at the bottom of the page or I can say in footer.

Error: "angular was used before it was defined" but online editors able to output the result

3 Answers3