Rails form show extra button on iteration

Question

This shows all the comments but it also shows an extra edit and delete button at the end. But when I reverse the order that is, I show Add comment after all the comments this bug seems to disappear. Anyone can point out what is happening? Also, I would like suggestions for better coding standards.

<div class="alert alert-success">
<h3>Add Comment</h3>
<%= form_for([@article, @article.comments.build]) do |f| %>
<%= f.text_field :name, size:80 %>
<%= f.submit "Comment", class: "btn btn-primary" %>
<% end %>
</div>

<h3>Comments</h3>

<% @article.comments.each do |comment| %>
<div class="alert alert-info">
    <h4><%= comment.name %></h4>
    <table>
        <tr>
            <td><%= link_to 'Edit', [comment.article, comment], method: :put, class: "btn btn-primary" %></td>
            <td><%= button_to 'Delete', [comment.article, comment], method: :delete, class: "btn btn-danger" %></td>
        </tr>
    </table>
</div>
<% end %>

As per your code,the behaviour is correct. What you want it do? — Pavan, Jun 28 '15 at 09:19
Why does it show an extra edit and delete button after all the comments have been displayed? — Souvik Das, Jun 28 '15 at 09:21
It shows both the buttons along with each comment. That's fine. And then after all comments have been displayed, it outputs an extra edit and delete button. Why? — Souvik Das, Jun 28 '15 at 09:23

score 0 · Answer 1 · answered Jun 28 '15 at 09:37

You have to tweak your code like this

<table>

  <% @articles.each do |article| %>
  <div class="alert alert-info">
    <tr>
      <td><h4><%= comment.name %></h4></td>
      <td><%= link_to 'Edit', [comment.article, comment], method: :put, class: "btn btn-primary" %></td>
      <td><%= link_to 'Delete', [comment.article, comment], method: :delete, class: "btn btn-danger" %></td>
    </tr>
</div>
<% end %>

</table>

Also use link_to not button_to.

Rails form show extra button on iteration

1 Answers1