setBackgroundColor changes color of more then the button

Question

I'm trying to set color to a button, but when I write:

 button.setBackgroundColor(getResources().getColor(R.color.white));

the button becomes white, but also some space around it (I have couple of buttons in linearLayout, so it looks like one big white button).

Anyone knows how to fix this?

Update: My XML:

   <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="horizontal"
        android:gravity="center"
        android:weightSum="2"
        android:layout_weight="1"
        >
        <Button
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:text="New Button"
            android:background="@android:color/white"
            android:id="@+id/button1"
            />
        <Button
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:text="New Button"
            android:id="@+id/button2"                
            />


    </LinearLayout>

Here the left button looks bigger then the right one because I changed its color

where are the ids of your buttons? how are you initializing it in java! and what is @+id/logo i don't see it anywhere — Ahmad Sanie, Jun 21 '15 at 07:55
I read your question sometimes and so confuse what's your real problem? — ThaiPD, Jun 21 '15 at 08:13
I wrote - the problem is that setting a button color makes the button bigger (some space around it becomes colored as well) — sagicoh, Jun 21 '15 at 08:16

score 3 · Accepted Answer · answered Jun 21 '15 at 08:36

3

It's because the default implementation of a button uses a custom drawable as the background and changing the background will override it and lose all the stylings.

Instead what you want to do is to overlay the existing background drawable with a color:

button.getBackground().setColorFilter(Color.RED, PorterDuff.Mode.MULTIPLY);

You could also find the default style that the button uses, copy it and change the colors there but that would be more work.

answered Jun 21 '15 at 08:36

Simas

43,548
10
88
116

Can you tell me the style's name or how to find it? I tried using the color filter - I think the MULTIPLY Mode isnt working – sagicoh Jun 21 '15 at 09:49
@user3142471 I've tried it and it works perfectly fine for the standard Button on API 22. The style depends on the theme you're using but you can probably find it via the attribute `android.R.style.Widget_Button`. Also [this question](http://stackoverflow.com/q/1521640/3249477) might have more information. – Simas Jun 21 '15 at 09:54

score 2 · Answer 2 · answered Jun 21 '15 at 08:04

2

you don't need to write that code in your activity

just in your XML :

<Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="New Button"
        android:background="#ffffff"
        android:id="@+id/button1"
        />
    <Button
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="New Button"
        android:id="@+id/button2"                
        />

visit this website for color codes:

http://color-hex.com

answered Jun 21 '15 at 08:04

I need to create the buttons in the code and still in the xml writing `android:background="#ffffff"` didnt change anything – sagicoh Jun 21 '15 at 08:13
1

no it changes color bro.just try my code its simple and working fine. also you can create color.XML file and put color codes in there – Jun 21 '15 at 08:25

score 1 · Answer 3 · answered Jun 21 '15 at 11:17

1

Set the height and width of of your button to an specific size not to wrap content if you use a background color.

answered Jun 21 '15 at 11:17

Also you can set some layout margine to give ieach some distance from others – Jun 21 '15 at 11:21

score 0 · Answer 4 · answered Jun 21 '15 at 08:46

Did you try

<?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="horizontal"
    android:gravity="center"
    android:weightSum="2"

    >
    <Button
        android:layout_weight="1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="New Button"
        android:background="@android:color/white"
        android:id="@+id/button1"
        />
    <Button
        android:layout_weight="1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="New Button"
        android:id="@+id/button2"                
        />


</LinearLayout>

In your parrent layout (LinearLayout) you set weightSum is 2 but not contribute for child by using android:layout_weight="1" in childs elements

I understand as you want to have 2 button with same size with above code, right? otherwise could you please tell me what is your expected? — ThaiPD, Jun 21 '15 at 09:45

score 0 · Answer 5 · answered Jun 05 '20 at 21:38

0

You can try in Xamarin

button.Background.SetColorFilter(Android.Graphics.Color.ParseColor("#f00ece"), Android.Graphics.PorterDuff.Mode.Multiply);

answered Jun 05 '20 at 21:38

Sheriff

738
10
20

setBackgroundColor changes color of more then the button

5 Answers5