0

I've created a folder on my C:\packages. Inside I've created two packages with identical Ids but have different versions. I the use Nuget.Core to create a LocalPackageRepository pointing to this directory.

When I query for the packages using respository.FindPackages("myId")both packages are correctly returned by the service. However, the IsLatestVersion is true for both packages, even though their versions are clearly different.

Things I've tried: I know these packages dicovered as OptimizedZipPackages looking through the source here, I cant find anything relevant to suggest an issue with the implementation.

I added the local repository to my Visual Studio NuGet feed manager. When I query that service, the latest version is shown.

Something seems to be wrong with how I've either created the packages, instantiated the repository, or its a bug in the library.

Using NuGet Core v2.8.60318.667

Community
  • 1
  • 1
cgatian
  • 22,047
  • 9
  • 56
  • 76

1 Answers1

1

Looking at the source code the LocalPackage always returns true for IsLatestVersion if the NuGet package is not a pre-release.

In Visual Studio what happens is that the list of packages is further filtered by removing all but the latest version in the list so you only ever see the latest version. One way to do this is to use extension methods included in NuGet:

packages.DistinctLast<IPackage>(PackageEqualityComparer.Id);

The DistinctLast method assumes that the same NuGet package id will appear together in the list otherwise it will not filter them correctly.

I believe you could also use the AsCollapsed extension method which is similar to the above. It basically does:

packages.DistinctLast<IPackage>(PackageEqualityComparer.Id, PackageEqualityComparer.Version);
Matt Ward
  • 47,057
  • 5
  • 93
  • 94
  • Matt, DistinctLast is an internal method, it doesnt look like that will work for me.https://github.com/mrward/nuget/blob/86a4b0fb0ecb8a75dae46073e54fb0e492f5ac6c/src/Core/Extensions/EnumerableExtensions.cs – cgatian Jun 11 '15 at 12:12
  • I was able to use the AsCollapsed as suggested:packageRepository.FindPackagesById(Id).AsCollapsed().First(); – cgatian Jun 11 '15 at 12:22
  • Let me know if you see a cleaner way to do this. Thank you again. – cgatian Jun 11 '15 at 12:23
  • Looks good to me. Ah, yes it is internal. I ended up re-using the DistinctLast code directly in Xamarin Studio and SharpDevelop. I think originally the AsCollapsed method did not exist in NuGet 1.0. Looking at the more recent code they are using the AsCollapsed method. – Matt Ward Jun 11 '15 at 12:51
  • Thanks again for your help. – cgatian Jun 11 '15 at 15:42