How to add a bunch of images to a zipfile

Question

I have a list of image filenames with about 150 entries. Every image is downloaded via urllib and stored on the system. The result is a zipfile containing several broken images. The last part of some images is missing / corrupt.

The image download works perfectly. Every image in the list is completely downloaded and a valid image. It looks like i have to wait until zf.write() is completely done until the next image is added. Is there a way to ensure this?

images = ['image-01.jpg', 'image-02.jpg', 'image-03.jpg']

zf = zipfile.ZipFile('file.zip', mode='w')

for image in images:

    download_url = 'http://foo/bar/' + image

    image_file = open(image, 'wb')
    image_file.write(urllib.urlopen(download_url).read())
    image_file.close

    zf.write(image)

zf.close()

You are not closing the `image_file`, replace `image_file.close` with `image_file.close()`. — alecxe, Jun 04 '15 at 22:08
That's the solution. Weird, there is no error when you run python in background. — Stefan Antonelli, Jun 04 '15 at 22:57

score 0 · Answer 1 · answered Jun 04 '15 at 23:02

0

Thanks to alecxe. The solution is to close the file correctly.

image_file.close()

answered Jun 04 '15 at 23:02

Stefan Antonelli

1
1

How to add a bunch of images to a zipfile

1 Answers1