zip creation error in java

Question

I am using ZipOutputStream,FileOutputStream and FileInputStream.

First I created a folder with one file. It successfully created. Then I tried to create zip files. Dynamically, it creates file first time correctly but at second time , third time it gives error while opening it.

Error: zip [path/././file.zip] Cannot open The process cannot access the file because it is being used by another process. I created following code in java,

My Code:

 demopath+="/myzip"+po.getPoid();
        createDir(demopath);
        createFileForFamilies("My content", demopath+"/file");
        this.zipDirectory(new File(demopath), demopath+".zip");

My file creator function:

public String createFileForFamilies(String content, String path) {
    FileOutputStream fop = null;
    File file;
    try {

        file = new File(path);
        fop = new FileOutputStream(file);

        // if file doesnt exists, then create it
        if (!file.exists()) {
            file.createNewFile();
        }

        // get the content in bytes
        byte[] contentInBytes = content.getBytes();

        fop.write(contentInBytes);
        fop.flush();
        fop.close();

        return ("Done");

    } catch (IOException e) {
        System.err.println(e);
        return ("Done");
    } finally {
        try {
            if (fop != null) {
                fop.close();
            }
        } catch (IOException e) {
            System.err.println(e);
            return ("Abort");

        }
    }
}

My Zip creation function:

public void zipDirectory(File dir, String zipDirName) {
    try {
        populateFilesList(dir);
        //now zip files one by one
        //create ZipOutputStream to write to the zip file
        FileOutputStream fos = new FileOutputStream(zipDirName);
        ZipOutputStream zos = new ZipOutputStream(fos);
        for (String filePath : filesListInDir) {
            System.out.println("Zipping " + filePath);
            //for ZipEntry we need to keep only relative file path, so we used substring on absolute path
            ZipEntry ze = new ZipEntry(filePath.substring(dir.getAbsolutePath().length() + 1, filePath.length()));
            zos.putNextEntry(ze);
            //read the file and write to ZipOutputStream
            FileInputStream fis = new FileInputStream(filePath);
            byte[] buffer = new byte[1024];
            int len;
            while ((len = fis.read(buffer)) > 0) {
                zos.write(buffer, 0, len);
            }
            zos.closeEntry();
            fis.close();

        }
        zos.close();
        fos.close();


    } catch (IOException e) {
        e.printStackTrace();
    }
}

I would suggest you simply use a [Zip File System Provider](https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystemprovider.html) - it would greatly simplify your code. — Boris the Spider, May 25 '15 at 12:26
Looks like you are leaking file handles somehow. You should always use a finally block (or try with resources in java 7/8) to close things like streams. — Jilles van Gurp, May 25 '15 at 13:49
@Boris: thank you, it works on other drives, but not working on c drive. — Chaitanya Joshi, May 26 '15 at 04:49

score 1 · Accepted Answer · answered May 26 '15 at 05:50

Thank you Boris...

This is a solution:

 Map<String, String> env = new HashMap<>();
    env.put("create", "true");
    // locate file system by using the syntax 
    // defined in java.net.JarURLConnection
    URI uri = URI.create("jar:file:/"+zipPath+".zip");

    try (FileSystem zipfs = FileSystems.newFileSystem(uri, env)) {
        java.nio.file.Path externalTxtFile;
        java.nio.file.Path pathInZipfile ;

        externalTxtFile = Paths.get(gamesPath);
        pathInZipfile = zipfs.getPath("/file.txt");
        Files.copy(externalTxtFile, pathInZipfile,
                StandardCopyOption.REPLACE_EXISTING);
        }

zip creation error in java

1 Answers1