Multiple MsgBoxes

Question

I keep receiving multiple MsgBoxes with the same error messages. How do I keep this from happening?

Private Sub BtnCalc_Click(sender As Object, e As EventArgs) Handles BtnCalc.Click
   Dim intValue1 As Integer
   Dim intValue2 As Integer
   Dim intValue3 As Integer

   intValue1 = Val(TBValue1.Text)
   intValue2 = Val(TBValue2.Text)
   intValue3 = Val(TBValue3.Text) 

   If IsNumeric(Val(TBValue1.Text)) Then
       If IsNumeric(Val(TBValue2.Text)) Then
           If Val(TBValue1.Text) > 0 Then
               If Val(TBValue2.Text) > 0 Then
                   If Val(TBValue1.Text) <> "" Then
                       If Val(TBValue2.Text) <> "" Then
                           TBValue3.Text = a + ((Val(TBValue1.Text) - >Val(TBValue2.Text)) * 10) 
                           If Val(TBValue1.Text) > Val(TBValue2.Text) + x 
                               Then MsgBox("Error2")
                           End If
                       Else : MsgBox("Error!")
                           TBValue1.Text = ""
                           TBValue2.Text = ""
                           TBValue3.Text = ""
                       End If
                   Else : MsgBox("Error!")
                       TBValue1.Text = ""
                       TBValue2.Text = ""
                       TBValue3.Text = ""
                   End If
               Else : MsgBox("Error!")
                   TBValue1.Text = ""
                   TBValue2.Text = ""
                   TBValue3.Text = ""
               End If
           Else : MsgBox("Error!")
               TBValue1.Text = ""
               TBValue2.Text = ""
               TBValue3.Text = ""
           End If
           MsgBox("Error!")
           TBValue1.Text = ""
           TBValue2.Text = ""
           TBValue3.Text = ""
       End If
       MsgBox("Error!")
       TBValue1.Text = ""
       TBValue2.Text = ""
       TBValue3.Text = ""
   End If    
End Sub 
End Class

It made my eyes bleed, but the last two MsgBox() calls belong inside an Else block. Don't write code like this. — Hans Passant, May 24 '15 at 14:52

score 0 · Answer 1 · answered May 24 '15 at 22:57

Private Sub BtnCalc_Click(sender As Object, e As EventArgs) Handles BtnCalc.Click
'
Dim intValue1 As Integer
Dim intValue2 As Integer
Dim intValue3 As Integer
'
intValue1 = Val(TBValue1.Text)
intValue2 = Val(TBValue2.Text)
intValue3 = Val(TBValue3.Text) 
'
If Val(TBValue1.Text) <> "" AND IsNumeric(Val(TBValue1.Text)) AND Val(TBValue1.Text) > 0 Then
  If Val(TBValue2.Text) <> "" AND IsNumeric(Val(TBValue2.Text)) AND Val(TBValue2.Text) > 0 Then
    TBValue3.Text = a + ((Val(TBValue1.Text) - >Val(TBValue2.Text)) * 10) 
    If Val(TBValue1.Text) > Val(TBValue2.Text) + x Then 
      MsgBox("Error2")
    End If
  Else 
    MsgBox("Error!")
    TBValue1.Text = ""
    TBValue2.Text = ""
    TBValue3.Text = ""
  End If
Else
  MsgBox("Error!")
  TBValue1.Text = ""
  TBValue2.Text = ""
  TBValue3.Text = ""
End If
End Sub

Multiple MsgBoxes

1 Answers1