Why is my MVC ViewModel Empty?

Question

Model:

public class Service
{
    public int Id { get; set; }
    public string Name { get; set; }
    public double Price { get; set; }
}

ViewModel:

public class FullPrice
{
    public IEnumerable<Service> Services { get; set; }
}

View:

@model hotel.Models.FullPrice
@foreach(Service service in Model.Services)
{
    //
}

My view model is NULL. Why?

You have to initialize it in the controller action before passing to the view. Show the action code. — Zabavsky, May 16 '15 at 19:09
FullPrice model = new FullPrice(); return View(model); this my Action — andrey1567, May 16 '15 at 19:19
you'll need to have some controller actions before you attempt to scaffold your views — Dan Beaulieu, May 16 '15 at 20:15

AmmarCSE · Answer 1 · 2015-05-16T21:17:56.887

Model would be NULL because there is no currently existing instance as the view is being executed.

Usually, the way to pass a model instance into a view would be in the corresponding action method like

public View myActionMethod()
{
    hotel.Models.FullPrice model = new hotel.Models.FullPrice();
    model.Services = new List<Service>();//Also prevent NULL exception with this property
    return View(model);
}

score 1 · Answer 2 · answered May 16 '15 at 19:22

1

I guess it's not the model what is null, but the Services. Change the action code to

FullPrice model = new FullPrice
{
    Services = new List<Service>()
};
return View(model);

answered May 16 '15 at 19:22

Zabavsky

13,340
8
54
79

score 0 · Answer 3 · answered May 19 '15 at 23:47

Change your ViewModel code to below

public class FullPrice
{
    public FullPrice()
    {
        this.Services = new List<Service>();
    }

    public IEnumerable<Service> Services { get; set; }
}

so the Services property won't be null when you do this

FullPrice model = new FullPrice();

Why is my MVC ViewModel Empty?

3 Answers3