3

well i'm still new in oracle, i'm trying to query a table with a subquery..it looks like this

select id_user, count(*) as jumlah from (select * from users where username = 'usr' and pass = 'pwd' and company_id = 'PAN' and status = 1) 
group by id_user;

the above code works. but when i try to put it inside a stored procedure i got some errors like this

here's the stored procedure

create type login_obj is object(jumlah integer);
create type login_table is table of login_obj;
create or replace function startLogin(u varchar, p varchar, cid varchar)
return login_table
is
  tabel login_table := login_table();
  the_count integer;
  the_sql varchar(200);
begin
  the_sql := 'select id_user, count(*) as jumlah from (select * from users where username = ''' || u || ''' and pass = ''' || p || ''' and company_id = ''' || cid || ''' and status = 1) GROUP BY id_user';
  execute immediate the_sql into the_count;

  if the_count IS NOT NULL
  then
  begin
    tabel.extend;
    tabel(1) := login_obj(the_count);
  end;
  end if;
  return tabel;
end;

then executing it by

select * from table (startLogin('usr','pwd','PAN'));

and here are the errors

SQL Error: ORA-00932: inconsistent datatypes: expected - got -
ORA-06512: at "LUKI.STARTLOGIN", line 14
00932. 00000 -  "inconsistent datatypes: expected %s got %s"

any idea?

thekucays
  • 568
  • 3
  • 9
  • 32

3 Answers3

3

Add one more variable below the line

the_sql varchar(200);

as

yid_user users.id_user%TYPE;

and change your execute immediate as

execute immediate the_sql into yid_user, the_count;

Also some tips for using variable types in Oracle:

1. VARCHAR is obsolete, use VARCHAR2 instead.
2. Instead of using INTEGER type, use NUMBER.
2

Your query returns 2 columns, but there's only one column defined in INTO.

dnoeth
  • 59,503
  • 4
  • 39
  • 56
1

i already figured it out.. thanks for user4884704 (i've marked his answer already)

so here's the working code..put the results in different variable

create type login_obj is object(id_user integer, jumlah integer);
create type login_table is table of login_obj;
create or replace function startLogin(u varchar, p varchar, cid varchar)
return login_table
is
  tabel login_table := login_table();
  id_user integer;
  the_count integer;
  the_sql varchar(200);
begin
  the_sql := 'select id_user, count(*) as jumlah from (select * from users where username = ''' || u || ''' and pass = ''' || p || ''' and company_id = ''' || cid || ''' and status = 1) GROUP BY id_user';
  execute immediate the_sql into id_user, the_count;

  if the_count IS NOT NULL
  then
  begin
    tabel.extend;
    tabel(1) := login_obj(id_user, the_count);
  end;
  end if;
  return tabel;
end;

then i execute it as

select * from table (startLogin('usr','pwd','PAN')); 
thekucays
  • 568
  • 3
  • 9
  • 32