Dead code using android eclipse

Question

I am working on android application in which i am using a logic to find the direction of a person from coordinated. Everything is working fine but i got error at console: : "Dead Code". My code is given below, please explain me this thing.

private void direction() {

        String userLocation = mLatitude + ","
                + mLongitude ;

        if(userLocation!=null){
            String distLocation = Constants.sMY_LOCATION.getLatitude() + ","
                    + Constants.sMY_LOCATION.getLongitude();
            String url = "https://maps.google.com/maps?f=d&saddr=" + userLocation
                    + "&daddr=" + distLocation;
            Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
            startActivity(i);
        }else{ // Getting Dead Code Yellow error here
            finish();
            Toast.makeText(getBaseContext(), "Please check your internet and try again!", Toast.LENGTH_SHORT).show();
        }


    }

`Dead Code` is code you don't use anymore, such as a method which is never called. It is **not an error**. — Phantômaxx, Apr 30 '15 at 09:31

score 6 · Accepted Answer · answered Apr 30 '15 at 09:32

6

It's because your else can't be reached

String userLocation = mLatitude + ","
            + mLongitude ;

    if(userLocation!=null){
       ...
    }else{
       ...
    }

userLocation will never be null

answered Apr 30 '15 at 09:32

Plumillon Forge

1,659
1
16
31

mlumeau · Answer 2 · 2015-06-08T14:33:06.717

2

The code in your else{} will never be reached because your string userLocation is initialized before the if statement, meaning it will never be null.

So the code in you else is effectively dead code.

edited Jun 08 '15 at 14:33

answered Apr 30 '15 at 09:33

mlumeau

821
1
8
20

score 1 · Answer 3 · answered Apr 30 '15 at 09:37

1

You should check mLatitude and mLongitude for being null instead of whole String.

Example:

if (mLatitude != null && mLongitude != null) {
   // String userLocation = ...
}
else {
   // Your else code
}

answered Apr 30 '15 at 09:37

Artrmz

340
2
14

Dead code using android eclipse

3 Answers3