Where to declare response.success()/response.error() in my cloud code

Question

Hi while I run this Job in Cloud code I get an error log: Failed with: success/error was not called. Define functions working good, but in Job logs I have this error log. Please assist me to solve the issue

Parse.Cloud.job("JobSchedule", function (request, response) {
        var Group = Parse.Object.extend("Group");
        var query = new Parse.Query(Group);
        query.equalTo("JobScheduled", true);
        query.find({
            success: function (results) {
                for (var i = 0; i < results.length; ++i) {
                    var created = new Date(results[i].createdAt);
                    var current = new Date();
                    var timeDiff = Math.abs(current.getTime() - created.getTime());
                    var horsDiff = timeDiff / (60 * 60 * 1000);
                    if (horsDiff >= parseInt(results[i].get("JobHours"))) {
                        results[i].set("JobScheduled", false);
                        results[i].set("GroupType", "Private");
                        results[i].set("JobHours", 0);
                        results[i].save();

                        var GroupMembers = Parse.Object.extend("GroupMembers");
                        var query1 = new Parse.Query(GroupMembers);
                        query1.equalTo("GroupId", results[i].id);
                        query1.find({
                            success: function (grpresults) {
                                for (var j = 0; j < grpresults.length; ++j) {
                                    grpresults[j].set("GroupType", "Private");
                                    grpresults[j].save();
                                }
                            },
                            error: function (error) {
                                response.error(error);
                            }

                        });
                    }
                }
            },
            error: function (error) {
                response.error(error);
            }
        });
    });

BHendricks · Accepted Answer · 2015-04-27T16:17:03.153

In each of your success scenarios, you need to call response.success(), where between the parenthesis you can return a status message, such as

response.success('Hello world did work');

In your case, this would probably go here:

Parse.Cloud.job("JobSchedule", function (request, response) {
    var Group = Parse.Object.extend("Group");
    var query = new Parse.Query(Group);
    query.equalTo("JobScheduled", true);
    query.find({
        success: function (results) {
            for (var i = 0; i < results.length; ++i) {
                var created = new Date(results[i].createdAt);
                var current = new Date();
                var timeDiff = Math.abs(current.getTime() - created.getTime());
                var horsDiff = timeDiff / (60 * 60 * 1000);
                if (horsDiff >= parseInt(results[i].get("JobHours"))) {
                    results[i].set("JobScheduled", false);
                    results[i].set("GroupType", "Private");
                    results[i].set("JobHours", 0);
                    results[i].save();

                    var GroupMembers = Parse.Object.extend("GroupMembers");
                    var query1 = new Parse.Query(GroupMembers);
                    query1.equalTo("GroupId", results[i].id);
                    query1.find({
                        success: function (grpresults) {
                            for (var j = 0; j < grpresults.length; ++j) {
                                grpresults[j].set("GroupType", "Private");
                                grpresults[j].save();

                            }
                            // HERE IS THE NEW CODE
                            response.success("Saved objects properly");

                        },
                        error: function (error) {
                            response.error(error);
                        }

                    });
                }
            }

        error: function (error) {
            response.error(error);
        }
    });
});

Thank you BHendricks for your reply. As your suggestion inner for loop (query1) is not working pls help me out to solve tis issue — Anbarasi, Apr 27 '15 at 11:53
Check my updated answer, I moved the success block to somewhere that should probably work better — BHendricks, Apr 27 '15 at 16:17
I have tried your updated solution. It works fine for single record. when it goes above 2 the inner for loop(i.e. query1) is not working further and it failed with a log, Can't call success/error multiple times — Anbarasi, Apr 28 '15 at 04:27

Where to declare response.success()/response.error() in my cloud code

1 Answers1