7

Maybe some will see that the question silly, however it is not.

I am asking where should Constant should live in Symfony2 Bundle, I used in other frameworks to create my constants variable in Models, however since in Symfony2 I am using Entity, I am a bit confused.

Should it live inside => Entity, Controller, Service or even config file.

Martin54
  • 1,349
  • 2
  • 13
  • 34
Dahab
  • 518
  • 1
  • 5
  • 23
  • 3
    Your question is a bit generic, it depends entirely on what constant you are defining. – Gerry Apr 20 '15 at 08:47

3 Answers3

14

I for my part like using Entity Constats for simple relations. Let's say for example you have an attribute of your entity called status that can only have values between 0-2. An extra status entity might be overkill in this scenario so I simply define them as constants:

class Entity {

    const STATUS_PUBLIC = 0;
    const STATUS_WAITING = 1;
    const STATUS_REJECTED = 2;

}

It allows you to simply check for a status by comparing to constants:

$entity->getStatus() == Entity::STATUS_PUBLIC

Or even in twig:

entity.status == constant('STATUS_PUBLIC', entity)

Or in a QueryBuilder:

$builder->andWhere('status = :status')
    ->setParameter('status', Entity::STATUS_PUBLIC)

It has proven to be quite effective for me.

As other answers point out for global constants should definitely be avoided. Use parameters for that.

As it seems to be unclear when to use Parameters:

Taken from the official best practice:

Creating a configuration option for a value that you are never going to configure just isn't necessary.

You might consider using parameters though if these values change. One example would be your application running in multiple environments. Using parameters will give you the power to adapt to environment changes without updating your code base.

ferdynator
  • 6,245
  • 3
  • 27
  • 56
  • Good point to place constants within entities. The problem which I'm facing is that my entities are generated by Doctrine and with each new entity generation the constants get lost. Is there a way to define entity constants in yml? – ninsky Sep 20 '15 at 12:22
  • @ninsky check [this answer](http://stackoverflow.com/a/32593584/1847340) out. maybe it helps. – ferdynator Sep 29 '15 at 12:08
  • thanks, but that doesn't help as there seems no way to define a constant in a doctrine yaml configuration to generate a doctrine entity with a "const CONST = 'const'" entry. The link in your answer just describes how to insert an "external" constant into a yaml file – ninsky Apr 11 '17 at 11:53
4

If you check a symfony bundle like "FOSUserBundle", you'll find some good usage and example for this.

There are constant definitions:

final class FOSUserEvents{
  const CHANGE_PASSWORD_INITIALIZE = 'fos_user.change_password.edit.initialize';
Tebe
  • 171
  • 1
  • 7
1

I don't think there is one good place for storing constant variables. It rather depends on what this constant variable is about: if this is related with entity it should be a entity's constant; if this is specific to service it should be service's constant.

One thing which should be avoided is putting constants in config file unless it's going to change often as described in Symfony best practices

Tomasz Madeyski
  • 10,742
  • 3
  • 50
  • 62