Is this jQuery correct?

Question

i would like to have smooth scroll effect on my page. And iv found this code

jQuery(function($) {
  $('a[href*=#]:not([href=#])').click(function() {
    if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname) {
      var target = $(this.hash);
      target = target.length ? target : $('[name=' + this.hash.slice(1) +']');
      if (target.length) {
        $('html,body').animate({
          scrollTop: target.offset().top
        }, 1000);
        return false;
      }
    }
  });
});

This is ok, but is not working with my "go top" link. So i check other pages with tutorial and do this:

jQuery(function($) {
  $('a[href*=#]:not([href=#])').click(function() {
    if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname) {
      var target = $(this.hash);
      target = target.length ? target : $('[name=' + this.hash.slice(1) +']');
      if (target.length) {
        $('html,body').animate({
          scrollTop: target.offset().top
        }, 1000);
        return false;
      }
    }
  });
  $('a.go-top').click(function() {
    $('html, body').animate({scrollTop:0}, 'slow');
    return false;
  });
});

And all is working fine now. but I have no idea about jQuery, could You tell me is this correct code, or if You can, what should i change here? Thanks!

I think that this question should have been posted on [**Code Review**](http://codereview.stackexchange.com/) — Artur Filipiak, Apr 19 '15 at 11:31
@ArturFilipiak To be on-topic for Code Review, the question must be posed by the author or maintainer of the code. You can't just ask for code reviews of random code that you found. — 200_success, Apr 19 '15 at 11:34
@ArturFilipiak It must be by the author. Artur, have a look at [this](http://codereview.stackexchange.com/help/on-topic). Near the bottom of the page is a little checklist - if you answer all the questions with a yes, it should be on CodeReview. One of the questions asks for it to be by the author — blaizor, Apr 19 '15 at 11:35

Tucker · Accepted Answer · 2015-04-19T12:36:09.263

1

It did not work with your go top link because you are looking only for a link with a id attributes to be clicked: $('a[href*=#]:not([href=#])'). Your go-top is a class not an id, if you were to change it to an id you would not need the code you added.

edited Apr 19 '15 at 12:36

answered Apr 19 '15 at 12:30

Tucker

659
4
16

Thank You for answer, iv changed this to id but still not working. What i have in a code: //* Add Go To Top button in footer add_filter( "genesis_structural_wrap-footer-widgets", 'sp_add_content_to_footer_wrap', 10, 2); function sp_add_content_to_footer_wrap( $output, $original_output ) { if( 'open' == $original_output ) { $output = '' . $output; } return $output; } – KamilT Apr 19 '15 at 12:40
Surprisingly that was not hard to read lol. Well you have to think about what your code is doing ``. Where is this linking to? The answer is it's not being linked to anywhere you just put the pound sign inside. And again, what do you think this code does `$('a[href*=#]:not([href=#])')`. It specifically does not match what you implemented, which is ``. You want to change `` to ``. – Tucker Apr 19 '15 at 13:10
Since you want to go to the top of your page you should make a div at the top of the page like `
` and change `` to ``.
– Tucker Apr 19 '15 at 13:19
I'm using genesis theme for WordPress and there is not any id element on top, so if i can't link to any # i must stay with this additional code: $('a.go-top').click(function() { $('html, body').animate({scrollTop:0}, 'slow'); return false; }); ? – KamilT Apr 19 '15 at 13:31
Keeping your additional code would be the simplest route. – Tucker Apr 19 '15 at 13:35

Is this jQuery correct?

1 Answers1